Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[added] Added an id prop, applied to the modal dialog (content) #765

Merged
merged 3 commits into from
Jul 14, 2019
Merged

[added] Added an id prop, applied to the modal dialog (content) #765

merged 3 commits into from
Jul 14, 2019

Conversation

YassienW
Copy link
Contributor

Fixes #763

Changes proposed:

  • Adding an 'id' prop to be passed to the dialog component

Acceptance Checklist:

  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.

@YassienW YassienW mentioned this pull request Jul 13, 2019
Closed
@coveralls
Copy link

coveralls commented Jul 13, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 86.652% when pulling 356941e on YassienW:master into d7ec04d on reactjs:master.

@diasbruno
Copy link
Collaborator

Hi @YassienW, it all looks good...can you add a test case for this, please?

@YassienW
Copy link
Contributor Author

Done

@diasbruno diasbruno merged commit c747c24 into reactjs:master Jul 14, 2019
@diasbruno
Copy link
Collaborator

Thanks, @YassienW.

@diasbruno
Copy link
Collaborator

Released 3.9.1.

@YassienW
Copy link
Contributor Author

Thank you for the quick release

nitzanmo added a commit to nitzanmo/DefinitelyTyped that referenced this pull request Feb 14, 2020
@nitzanmo
Added id attribute, as per PR reactjs/react-modal#765
bb231cf
PranavSenthilnathan pushed a commit to DefinitelyTyped/DefinitelyTyped that referenced this pull request Feb 18, 2020
@nitzanmo
[react-modal] Added id attribute, as per PR https://github.com/reactj…
13322c9 
…s/react-modal/765 (#42370)

* Added id attribute, as per PR reactjs/react-modal#765

* Updated header

* Pr fixes
programmer4web pushed a commit to programmer4web/react-modal that referenced this pull request Oct 5, 2020
@YassienW @programmer4web
[added] Added an id prop, applied to the modal dialog (content) (reac…
2b7c7dc 
…tjs#765)

* Added an ID prop, applied to the modal dialog.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is it possible to pass an 'id' prop?
3 participants
@YassienW @coveralls @diasbruno