[fixed] some untabbable elements are being returned from findTabbable #774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #732
Changes proposed:
The bug in the example stems from the
hidesContents
function intabbable.js
returning false on the button with thedisplay: none
inline style. It is returning false because the element has the computed styleoverflow: visible
(which is default value).The problem with this is that having
overflow: visible
doesn't mean there is any content that is overflowing.I think there are a couple possible ways to fix this. One would be to add an additional check for the
display: none
style ifzeroSize === true
, which would directly solve the bug in the example.I'm not sure that will catch every possibility, so instead I check the elements
scrollWidth
andscrollHeight
to determine whether or not there is any overflowing content.Acceptance Checklist:
CONTRIBUTING.md
.