Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[fixed] switched from KeyboardEvent.keyCode to KeyboardEvent.code #953

Merged
merged 5 commits into from
Oct 14, 2022
Merged

[fixed] switched from KeyboardEvent.keyCode to KeyboardEvent.code #953

merged 5 commits into from
Oct 14, 2022

Commits on Jun 13, 2022

  1. [fixed] switched from KeyboardEvent.keyCode to KeyboardEvent.code 

    KeyboardEvent.keyCode is deprecated. Since React 18 dropped support for IE, we don't need to fall back on it and can simply switch to the new property, KeyboardEvent.code.
    Robin Métral committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    db05354 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. [fixed] address review comments

    Robin Métral committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    f88b5a0 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. [fixed] Fix missing returns in keydown helpers

    Robin Métral committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    18e7ec5 View commit details
    Browse the repository at this point in the history

  2. [fixed] Revert changes to test helpers

    Robin Métral committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    15cfb0f View commit details
    Browse the repository at this point in the history

  3. Add tests 

    - extend dispatchMockEvent test helper to support both keyCode and code
- duplicate two tests to cover the KeyboardEvent.code logic via escKeyDownWithCode and tabKeyDownWithCode
    Robin Métral committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    fd62ef5 View commit details
    Browse the repository at this point in the history