Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[fixed] element with display 'contents' is visible and is tabbable #969

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

galexandrade
Copy link
Contributor

Fixes #905.

This PR is a follow-up of #906 addressing the PR feedback.

Changes proposed:

  • element with display 'contents' is visible and is tabbable.

Upgrade Path (for changed or removed APIs):

  • none

Acceptance Checklist:

  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

@galexandrade
Copy link
Contributor Author

@aloker @diasbruno I have opened this PR just so we have the latest master on the branch. I've also addressed the PR comments on #906.

I'd appreciate if you guys could take a look and review it, please 🙏

@diasbruno
Copy link
Collaborator

Awesome, @galexandrade.
Everything looks great. I'll merge and make a release tomorrow.

@galexandrade
Copy link
Contributor Author

Awesome, @galexandrade. Everything looks great. I'll merge and make a release tomorrow.

Thank you. I appreciate

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabbing not possible inside display: contents
2 participants