Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Typescript support section: mention server_renderer_extensions #1054

Merged
merged 1 commit into from
May 12, 2020

Conversation

ostrgard
Copy link
Contributor

Recommend setting the server_renderer_extensions config option in the Typescript support section.

I experienced issues with changes to tsx and ts files not being properly updated in development. After loads of research on various levels of setup, I ran into this issue, which thankfully had a fix (I felt equally stupid as the author). I'd say typescript support is incomplete without the server_renderer_extensions config. Anything else delivers a subpar development experience.

I hope you sill consider my addition to the README, and thanks for all the work you put into this lib 👍

Recommend setting the `server_renderer_extensions` config option.
@BookOfGreg
Copy link
Member

In the docs you present it as a recommendation, I appreciate that as the user always has choice.
Thank you for the contribution!

@BookOfGreg BookOfGreg merged commit c93f6ee into reactjs:master May 12, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants