Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

📝: Update README.md [ci skip] #1102

Merged
merged 1 commit into from
Jun 16, 2021
Merged

📝: Update README.md [ci skip] #1102

merged 1 commit into from
Jun 16, 2021

Conversation

jae-mon
Copy link
Contributor

@jae-mon jae-mon commented Feb 24, 2021

Summary

Added a note to point 2 of the header 'Get Started With Webpacker'.
For Rails 6, the line gem 'webpacker' is not needed in the gemfile, as
it is already added by default.

Other Information

Leaving in the line generates an error when bundle install is run:
"You cannot specify the same gem twice with different version requirements.
You specified: webpacker (>= 0) and webpacker (~> 4.0)"

@jae-mon jae-mon closed this Apr 20, 2021
@jae-mon jae-mon changed the title 📝 Update README.md 📝: Update README.md [ci skip] Apr 20, 2021
@jae-mon jae-mon reopened this Apr 20, 2021
Copy link
Member

@BookOfGreg BookOfGreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I'd also welcome a PR that changes the default to assume webpack and have a note to add if less than Rails 6. I'd imagine there are more new Rails 6 projects today than 5 so.

@BookOfGreg BookOfGreg merged commit 484adf4 into reactjs:master Jun 16, 2021
@jae-mon
Copy link
Contributor Author

jae-mon commented Jun 16, 2021

Approved. I'd also welcome a PR that changes the default to assume webpack and have a note to add if less than Rails 6. I'd imagine there are more new Rails 6 projects today than 5 so.

Thank you for approving my PR. I will also work on the PR you suggested for changing the default to assume webpack.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants