Don't unmount components on Turbolinks navigation #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[As discussed in reactjs#1028](reactjs#1028 (comment)), unmounting components on `turbolinks:before-render` prevents Turbolinks from restoring the scroll position when navigating back to pages with tall React components. This happens because Turbolinks tries to restore the scroll position before firing the `turbolinks:load` event. Since components were unmounted prior to this, the page might be much shorter than it will be after mounting components causing scroll position restoration to fail. We've been running this in production for a week now and haven't noticed any issues caused by not unmounting components.
|
@BookOfGreg Hi! Would it be possible to get a new react_ujs release incorporating this fix? Or at least to get it into react_ujs/dist? We'd love to use it via https://www.npmjs.com/package/react_ujs. |
|
@BookOfGreg Hi! Sorry to bother you – just wanted to check again if I could encourage either a new release or to get this change into dist? |
|
Updated to 2.6.2 and it seems to work. Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1028, unmounting components on
turbolinks:before-renderprevents Turbolinks from restoring the scroll position when navigating back to pages with tall React components. This happens because Turbolinks tries to restore the scroll position before firing theturbolinks:loadevent. Since components were unmounted prior to this, the page might be much shorter than it will be after mounting components causing scroll position restoration to fail.We've been running this in production for a week now and haven't noticed any issues caused by not unmounting components.