Fix test suite #1148
Merged
Fix test suite #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mimemagic` removed version 0.3.3 (up through 0.3.6) and it was preventing the appraisal tests from running. This update was first started in reactjs#1114.
The `webpack-dev-server` package for the dummy test app was locked to a version that required webpack 4. Since the dummy is created for webpack 3, this was causing the builds to fail. In the future, we will need to add more support for the different webpack versions to make sure that the functionality is supported.
This was lagging behind the current version and would automatically jump up when the tests pass.
|
Anyone working on stabilizing the tests here is 👍 in my books. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, if you pull down the app to do any work to contribute, and you run the tests, there are many errors that will pop up preventing you from being able to run the test suite.
The intention of this PR is to get the tests in working order so that we can build more tests to make sure that support for newer features, like webpack 5, are supported.
The issues lies in 2 main places:
webpack-dev-serverto2.11.5, which is the last update that supports webpack 3.Other Information
This PR purposefully does not add more tests, but I intend to make another PR after this one that will do more to make sure that webpack 4 and 5 are testing building with the correct javascript libraries. Currently, they are only built with the one in the dummy app which is statically locked to webpack 3, even though the tests refer to it running as webpack 4.
I think it could be beneficial to rename that build for now until we can get to making sure that it is properly tested.
In addition to the change, running the tests bumped the version of react_ujs in the package.json to the current version, so I thought it sane to commit it. I can easily remove that if that should be handled by the travis run.