This repository was archived by the owner on Oct 26, 2018. It is now read-only.
Fix basename path issues #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jlongster Should we release a |
This was referenced Dec 10, 2015
Closed
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102 #103
The problem with relying on
history.createPathis that it might change in ways we don't want it to, e.g. as here whenhistory.createPathprepends the basename, which means that the input topushPathwill differ from the path we create on a location change.I think a good first step is to create the path ourselves (as we did in the previous version), and going forward to think about the ideas in #95 for later versions.
Thanks @dtryon and @hunterc for helping to fix this