Skip to content
This repository was archived by the owner on Oct 26, 2018. It is now read-only.

Support history 3 #476

Merged
merged 1 commit into from
Oct 25, 2016
Merged

Support history 3 #476

merged 1 commit into from
Oct 25, 2016

Conversation

just-boris
Copy link
Contributor

Fixes #475.

The idea how to determine new version of history I took from react-router source code

@timdorr
Copy link
Member

timdorr commented Oct 25, 2016

That was easy 😄

Lemme test a few things and then I'll release this, provided it works OK.

@dlmr
Copy link
Contributor

dlmr commented Nov 3, 2016

Is there anything I can help with to release a new version that adds this feature?

@yoadsn
Copy link

yoadsn commented Nov 3, 2016

Updating to latest react-router (3.0.0) and latest react-router-redux (4.0.6) breaks with async ssr use-case. The state is sent to the client with an empty location (expected?) and no location is found on state upon calling the "match" again - this throws since location is expected in react-router for "match" to work.

This is most likely due to the mismatch with history 3.0.0 - and not getting the current location from it. (no auto "listener" call on 3.0.0).

I think it's worth trying again with this PR applied - but still waiting for it to land on npm.
(Currently don't have time to build locally and test).

If this is pending for some reason and I can help with something (problem repro, testing local build) let me know and I'll try to clear up time for it.

@timdorr
Copy link
Member

timdorr commented Nov 3, 2016

Pushed out 4.0.7

@yoadsn
Copy link

yoadsn commented Nov 4, 2016

This solved the problem for me.
Thanks!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants