Fix setup page #7607
Fix setup page #7607
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
| @@ -23,10 +23,6 @@ React Developer Tools is a browser extension that can inspect React components, | |||
|
|
|||
| React Compiler is a tool that automatically optimizes your React app. [Learn more](/learn/react-compiler). | |||
|
|
|||
| ## Start a React Project from scratch {/*start-a-react-project-from-scratch*/} | |||
|
|
|||
| If you want to build your own framework, you can [start a React project from scratch](/learn/start-a-react-project-from-scratch). | |||
There was a problem hiding this comment.
instead of being deleted, this should probably point to /learn/building-a-react-framework?
There was a problem hiding this comment.
Hi @gaearon, Apologies, I should have clarified my rationale. I initially wanted to link /learn/building-a-react-framework too. However, it felt out of place in the Setup page, since the /learn/building-a-react-framework page is already linked in the Installation page.
@rickhanlonii Could you please clarify if the /learn/building-a-react-framework page should be linked here or if the section should be removed entirely?
There was a problem hiding this comment.
Note that the /learn/building-a-react-framework page just got renamed to /learn/build-a-react-app-from-scratch in #7624
Also /learn/start-a-react-project-from-scratch seems to not be a valid url anymore (but this url is still mentioned on the learn/setup page) :
I guess the section should be renamed or removed, currently the url is not valid and results in a "not found" error.
Edit : saw afterwards that other issues already mention this "not found" error for the link and it's why this PR exists, hope a decision will be made
|
Yeah this section shouldn't be here, the Setup section is it's own group now. There was an old commit on that PR that had Start a React App from Scratch under Setup, which was moved under Installation and renamed to Building a React framework, which was now renamed to Build a React App from Scratch, but still under installation. |
Fixes #7606
Fixes #7498