fix(reference): missing parameter in hydrateRoot #7724
Conversation
|
Hi @Kafuu-Chinocya! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
| import { reportCaughtError } from "./reportError"; | ||
|
|
||
| const container = document.getElementById("root"); | ||
| const root = hydrateRoot(container, { | ||
| const root = hydrateRoot(container, <App />, { |
There was a problem hiding this comment.
Nice catch but this causes a crash now:
This happens because the lines listed on 381 are now off by one. Can you update it so it still highlights like this:
There was a problem hiding this comment.
Och! Thank for the catch, Let me fix it.
Fix missing parameter issue for in hydrateRoot