Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs(cn): translate content/docs/addons-test-utils.md into Chinese #10

Merged
merged 5 commits into from
Feb 18, 2019

Conversation

caiyongmin
Copy link

Please review this PR!

@@ -263,7 +262,7 @@ findRenderedComponentWithType(
)
```

Same as [`scryRenderedComponentsWithType()`](#scryrenderedcomponentswithtype) but expects there to be one result and returns that one result, or throws exception if there is any other number of matches besides one.
功能类似于 [`scryRenderedComponentsWithType()`](#scryrenderedcomponentswithtype),但是预计只有一个结果,然后返回这个结果,如果除了一个匹配项之外还有其他匹配项,则抛出异常。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

功能类似于 scryRenderedComponentsWithType(),仅进行一个组件类型的匹配并且返回。如果匹配出的数量非一,则抛出异常。

Copy link
Author

@caiyongmin caiyongmin Feb 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“非一” 这个表述有些个人化了,个人觉得这里还是直译比较好。因为看其他文档翻译也有类似这样的翻译句式

@QC-L QC-L added the Pending Modify 已校对,待修改阶段 label Feb 12, 2019
@QC-L QC-L added Pending Re-Review 已修改,待审校阶段 and removed Pending Modify 已校对,待修改阶段 labels Feb 12, 2019
@QC-L QC-L added Pending Modify 已校对,待修改阶段 and removed Pending Re-Review 已修改,待审校阶段 labels Feb 13, 2019
@QC-L QC-L mentioned this pull request Feb 14, 2019
@QC-L QC-L added Pending Re-Review 已修改,待审校阶段 and removed Pending Modify 已校对,待修改阶段 labels Feb 15, 2019
Copy link
Member

@hijiangtao hijiangtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@hijiangtao
Copy link
Member

@sang4lv 除「非一」的表述存在争议,其余提及的内容译者已经做过修改了哈,故将你的 review 建议状态更改为 comments.

@hijiangtao hijiangtao dismissed sang4lv’s stale review February 18, 2019 03:23

@sang4lv 除「非一」的表述存在争议,其余提及的内容译者已经做过修改了哈,故将你的 review 建议状态更改为 comments

@sang4lv
Copy link
Collaborator

sang4lv commented Feb 18, 2019

LGTM

@hijiangtao hijiangtao merged commit 4df7405 into reactjs:cn Feb 18, 2019
@hijiangtao
Copy link
Member

「非一」问题讨论后单独 commit

OhIAmFine pushed a commit to OhIAmFine/zh-hans.reactjs.org that referenced this pull request May 6, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Pending Re-Review 已修改,待审校阶段
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants