-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
docs(cn): translate content/warnings/legacy-factories.md into Chinese #113
Conversation
Deploy preview for cn-reactjs ready! Built with commit 899a14f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一个小建议,其他的 LGTM
content/warnings/legacy-factories.md
Outdated
|
||
If you get a component class from a dynamic source, then it might be unnecessary to create a factory that you immediately invoke. Instead you can just create your element inline: | ||
如果从动态来源取得组件类,那么就不需要创建立即调用的工厂函数。相反,你可以直接内联地创建你的元素: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这句话稍微有些生硬,这样修改如何?
你可以通过内联的方式创建你的元素
content/warnings/legacy-factories.md
Outdated
@@ -1,22 +1,22 @@ | |||
--- | |||
title: React Element Factories and JSX Warning | |||
title: 警告:有关 React 元素工厂和 JSX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
元素工厂 感觉怪怪的,Element是大写的 要不直接就不要翻译了
Deploy preview for zh-hans-reactjs ready! Built with commit 06b08ec |
Deploy preview for zh-hans-reactjs ready! Built with commit 899a14f |
https://stackblitz.com/edit/react-legacy-factories
无法重现这个 warning