Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs(cn): translate content/warnings/legacy-factories.md into Chinese #113

Merged
merged 5 commits into from Mar 20, 2019
Merged

docs(cn): translate content/warnings/legacy-factories.md into Chinese #113

merged 5 commits into from Mar 20, 2019

Conversation

seognil
Copy link
Contributor

@seognil seognil commented Feb 17, 2019

@seognil seognil changed the title docs(cn): content/warnings/legacy-factories.md into Chinese docs(cn): translate content/warnings/legacy-factories.md into Chinese Feb 17, 2019
@netlify
Copy link

netlify bot commented Feb 17, 2019

Deploy preview for cn-reactjs ready!

Built with commit 899a14f

https://deploy-preview-113--cn-reactjs.netlify.com

@seognil seognil mentioned this pull request Feb 17, 2019
@QC-L QC-L added the Pending Review 已翻译,待校对阶段 label Feb 17, 2019
Copy link
Collaborator

@sang4lv sang4lv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一个小建议,其他的 LGTM


If you get a component class from a dynamic source, then it might be unnecessary to create a factory that you immediately invoke. Instead you can just create your element inline:
如果从动态来源取得组件类,那么就不需要创建立即调用的工厂函数。相反,你可以直接内联地创建你的元素:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这句话稍微有些生硬,这样修改如何?

你可以通过内联的方式创建你的元素

@@ -1,22 +1,22 @@
---
title: React Element Factories and JSX Warning
title: 警告:有关 React 元素工厂和 JSX
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

元素工厂 感觉怪怪的,Element是大写的 要不直接就不要翻译了

@QC-L QC-L merged commit 6ebb04d into reactjs:master Mar 20, 2019
@netlify
Copy link

netlify bot commented Mar 20, 2019

Deploy preview for zh-hans-reactjs ready!

Built with commit 06b08ec

https://deploy-preview-113--zh-hans-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Mar 20, 2019

Deploy preview for zh-hans-reactjs ready!

Built with commit 899a14f

https://deploy-preview-113--zh-hans-reactjs.netlify.com

OhIAmFine pushed a commit to OhIAmFine/zh-hans.reactjs.org that referenced this pull request May 6, 2019
@awxiaoxian2020 awxiaoxian2020 removed the Pending Review 已翻译,待校对阶段 label Feb 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants