docs(cn): translate content/docs/forwarding-refs.md into Chinese #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for cn-reactjs ready! Built with commit 13d2793 |
Closed
robertying
requested changes
Feb 18, 2019
…description to make the doc easier to understand.
2. Update glossary translation. 3. Update format.
|
Deploy preview for zh-hans-reactjs ready! Built with commit 13d2793 |
yuqingc
requested changes
Apr 3, 2019
content/docs/forwarding-refs.md
Outdated
|
|
||
| For example, the following component will appear as "*ForwardRef*" in the DevTools: | ||
| 示例，以下组件将在 DevTools 中显示为 “*ForwardRef*”： |
There was a problem hiding this comment.
中文全角符号两侧不需要空格。
Suggested change
| 示例，以下组件将在 DevTools 中显示为 “*ForwardRef*”： | |
| 示例，以下组件将在 DevTools 中显示为“*ForwardRef*”： |
|
@robertying @yuqingc 感谢两位大佬~ |
robertying
previously approved these changes
Apr 12, 2019
yuqingc
previously approved these changes
Apr 12, 2019
Lmagic16
reviewed
Apr 13, 2019
Lmagic16
reviewed
Apr 13, 2019
content/docs/forwarding-refs.md
Outdated
|
|
||
| **When you start using `forwardRef` in a component library, you should treat it as a breaking change and release a new major version of your library.** This is because your library likely has an observably different behavior (such as what refs get assigned to, and what types are exported), and this can break apps and other libraries that depend on the old behavior. | ||
| **当你开始在组件库中使用 `forwardRef` 时，你应当将其作为一个破坏性更改，并发布库的一个新的主板本。** 这是因为你的库可能会有明显不同的行为（例如 refs 被分配给了什么，以及导出了什么类型），并且这样可能会导致依赖旧行为的应用和其他库崩溃。 |
There was a problem hiding this comment.
Suggested change
| **当你开始在组件库中使用 `forwardRef` 时，你应当将其作为一个破坏性更改，并发布库的一个新的主板本。** 这是因为你的库可能会有明显不同的行为（例如 refs 被分配给了什么，以及导出了什么类型），并且这样可能会导致依赖旧行为的应用和其他库崩溃。 | |
| **当你开始在组件库中使用 `forwardRef` 时，你应当将其视为一个破坏性更改，并发布库的一个新的主版本。** 这是因为你的库可能会有明显不同的行为（例如 refs 被分配给了谁，以及导出了什么类型），并且这样可能会导致依赖旧行为的应用和其他库崩溃。 |
There was a problem hiding this comment.
what refs get assigned to
字面上理解 应该是指什么， 但是此处用谁好像更通顺一点。但在不影响表意的情况下，个人倾向于更遵照直译，大佬怎么看？
There was a problem hiding this comment.
额 这里是第一次读的时候觉得有点怪，不过确实不影响表意。遵照直译吧~
2. Modify part description.
QC-L
previously approved these changes
Apr 14, 2019
QC-L
approved these changes
Apr 15, 2019
yuqingc
approved these changes
Apr 15, 2019
OhIAmFine
pushed a commit
to OhIAmFine/zh-hans.reactjs.org
that referenced
this pull request
May 6, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate content/docs/forwarding-refs.md into Chinese.