Update TLS configuration defaults in javadoc #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
simonatan
commented
Oct 22, 2023
simonatan
commented
- 3s for close_notify flush timeout
- 0s for close_notify read timeout
- 3s for close_notify flush timeout - 0s for close_notify read timeout
|
@simonatan Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@simonatan Thank you for signing the Contributor License Agreement! |
violetagg
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
@simonatan Thanks for the PR!
@reactor/netty-team PTAL
The failing tests on CI are not relevant to this change.
pderop
approved these changes
Oct 23, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.