Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Explicit close of unwrapped stream should not emit error event #8

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Explicit close of unwrapped stream should not emit error event #8

merged 1 commit into from
Nov 28, 2017

Conversation

clue
Copy link
Member

@clue clue commented Nov 28, 2017

No description provided.

@clue clue added the bug label Nov 28, 2017
@clue clue added this to the v1.1.0 milestone Nov 28, 2017
WyriHaximus
WyriHaximus approved these changes Nov 28, 2017
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jsor jsor merged commit 1793f25 into reactphp:master Nov 28, 2017
@clue clue deleted the close-event branch November 28, 2017 17:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@jsor jsor jsor approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clue @jsor @WyriHaximus