Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Severe bug triggered by mplain with --presets-word #160

Closed
readbeyond opened this issue Feb 15, 2017 · 2 comments
Closed

Severe bug triggered by mplain with --presets-word #160

readbeyond opened this issue Feb 15, 2017 · 2 comments
Labels

Comments

@readbeyond
Copy link
Owner

readbeyond commented Feb 15, 2017

#Reported by QA Collective. Confirmed.

See: https://groups.google.com/forum/#!topic/aeneas-forced-alignment/NnpyiejGkHk

There are actually two different issues:

  1. in the recursion for mplain it might happen that at level 2 a sentence with more than one word gets assigned a zero-length time interval: in that case, at level 3 a trivial tree should be returned, without running the DTW: this can be solved modifying executetask.py;

  2. however, it might happen that a sentence gets assigned a non-zero-length interval (at level 2), but after MFCC masking, it becomes zero-length: this must be dealt with in dtw.py in the private _setup_dtw().

@readbeyond readbeyond added the bug label Feb 15, 2017
@readbeyond
Copy link
Owner Author

I have coded a tentative fix, I need to run tests before pushing to devel.

pettarin pushed a commit to pettarin/aeneas that referenced this issue Feb 15, 2017
readbeyond added a commit that referenced this issue Feb 15, 2017
@readbeyond
Copy link
Owner Author

Fixed and merged on devel. Closing.

cbenhagen pushed a commit to cbenhagen/aeneas that referenced this issue Aug 27, 2017
andreasscherman pushed a commit to andreasscherman/aeneas that referenced this issue Jan 11, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant