fix: better tag handling #991
Merged
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Also is there a reason not to do this in our new |
Yea, should I put up a PR to accept additional compilers instead? And move this into the monorepo? |
rafegoldberg
approved these changes
Oct 11, 2024
|
@kellyjosephprice—yeah, ^that could be a nice convenience! |
rafegoldberg
pushed a commit
that referenced
this pull request
Oct 14, 2024
## Version 7.6.7 ### ✨ New & Improved * **Image:** match new alignment selectors ([#992](#992)) ([73bca2b](73bca2b)) ### 🛠 Fixes & Updates * better tag handling ([#991](#991)) ([e6aa82d](e6aa82d)) * respect the top-level `copyButtons` option ([#990](#990)) ([1242413](1242413)), closes [#964](#964) [/github.com/readmeio/markdown/blob/96f9644f04e6d8e3ffff6f9c014432f901c0b804/lib/compile.ts#L28](https://github.com/readmeio//github.com/readmeio/markdown/blob/96f9644f04e6d8e3ffff6f9c014432f901c0b804/lib/compile.ts/issues/L28) [/github.com/readmeio/markdown/blob/96f9644f04e6d8e3ffff6f9c014432f901c0b804/lib/compile.ts#L28](https://github.com/readmeio//github.com/readmeio/markdown/blob/96f9644f04e6d8e3ffff6f9c014432f901c0b804/lib/compile.ts/issues/L28) [/github.com/readmeio/markdown/blob/b9502adb306f099cd91e005df17c0be252019814/options.js#L1-L22](https://github.com/readmeio//github.com/readmeio/markdown/blob/b9502adb306f099cd91e005df17c0be252019814/options.js/issues/L1-L22) ### 📘 Tests & Docs * readme updates ([#993](#993)) ([3a4e30d](3a4e30d)) <!--SKIP CI-->
|
This PR was released!🚀 Changes included in v7.6.7 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Don't attempt to migrate inline html tags.
remarkonly parses the tags, so something like:becomes:
🧬 QA & Testing
This shouldn't effect production code directly, only the migration. I think it's best to test directly in the migration?