Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mark tests that use the network #462

Closed
wants to merge 1 commit into from

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Jul 8, 2024

These two tests uses intersphinx, and the marker allows skipping them if there is no network available.

@AWhetter
Copy link
Collaborator

Thanks for making this change. Why is this needed?

@QuLogic
Copy link
Contributor Author

QuLogic commented Aug 18, 2024

This is useful for downstream packaging; in such cases builds aren't allowed to access the Internet at large, and instead of skipping all tests, it is useful to skip only the ones that require networking. I don't know that network is a standard name anywhere, but at least it's the one I suggest when making PRs like this.

@cclauss
Copy link
Contributor

cclauss commented Oct 12, 2024

To get the GitHub Actions to pass...

echo "Mark pytests that use the network" > docs/changes/462.misc.rst
git add docs/changes/462.misc.rst
git commit -m"git add docs/changes/462.misc.rst"
git push

@QuLogic QuLogic force-pushed the test-network-marker branch from 30e3375 to 486e78e Compare October 12, 2024 03:58
These two tests uses intersphinx, and the marker allows skipping them if
there is no network available.
@QuLogic QuLogic force-pushed the test-network-marker branch from 486e78e to eb80a58 Compare October 12, 2024 03:59
@QuLogic
Copy link
Contributor Author

QuLogic commented Oct 12, 2024

Thanks for the ping; I've fixed that, and the conflict.

@AWhetter
Copy link
Collaborator

Thanks for fixing this yourself and keep the pull request up to date. I've merged this as 0d5f21b

@AWhetter AWhetter closed this Oct 25, 2024
@QuLogic QuLogic deleted the test-network-marker branch October 26, 2024 06:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants