Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use valid XHTML syntax #985

Closed
pmoura opened this issue Jul 31, 2020 · 4 comments · Fixed by #1006
Closed

Use valid XHTML syntax #985

pmoura opened this issue Jul 31, 2020 · 4 comments · Fixed by #1006
Labels
Improvement Minor improvement to code

Comments

@pmoura
Copy link

pmoura commented Jul 31, 2020

The following lines:

<meta charset="utf-8">
{{ metatags }}
<meta name="viewport" content="width=device-width, initial-scale=1.0">

should be:

<meta charset="utf-8" /> 
{{ metatags }} 
<meta name="viewport" content="width=device-width, initial-scale=1.0" /> 
@utzig
Copy link

utzig commented Jul 31, 2020

Not really, <meta> tags are empty elements: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta

@pmoura
Copy link
Author

pmoura commented Jul 31, 2020

Without these fixes we get invalid EPUB files due to invalid XHTML (not HTML!) files.

@pmoura
Copy link
Author

pmoura commented Jul 31, 2020

P.S. Same fixes have already been applied to the themes bundled with Sphinx (in July 17): sphinx-doc/sphinx@267eeab

@pmoura
Copy link
Author

pmoura commented Aug 10, 2020

In the just released Sphinx Release 3.2.0, the bug fix is listed as:

#7846: html theme: XML-invalid files were generated

@stsewd stsewd added the Improvement Minor improvement to code label Oct 7, 2020
stsewd added a commit that referenced this issue Oct 7, 2020
SimonMellerin pushed a commit to makinacorpus/makina-sphinx-theme that referenced this issue Nov 19, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants