Fix field list with long terms #1137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, fieldlist extend the full content and may even overflow. Now with this patch, terms are limited to 20% of the field list. This patch also refactors the margin to be handled by css grid gap property. Possible future changes: These are things that I have noticed that can be fixed in future patches. - Remove left padding -- seems unnecessary to me - Remove bottom margin on last child globally - Collapse grid on mobile
|
Could this have a review, here is a bug report we got about this issue: https://developer.blender.org/T100721 |
benjaoming
approved these changes
Sep 1, 2022
|
I think that @agjohnson is trying to wrap up 1.1 for an imminent release. So targeting this for 2.0. I know that it's just a small fix, but I think @agjohnson appreciates keeping the work load minimal for the release to come out. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, fieldlist extend the full content and may even overflow. Now with this patch, terms are limited to 20% of the field list.
This patch also refactors the margin to be handled by css grid gap property.
Possible future changes:
These are things that I have noticed that can be fixed in future patches.