Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

TrailingNewlineRule.swift doesn't seem to work #43

Closed
rajohns08 opened this issue May 27, 2015 · 4 comments · Fixed by #46
Closed

TrailingNewlineRule.swift doesn't seem to work #43

rajohns08 opened this issue May 27, 2015 · 4 comments · Fixed by #46
Labels
bug Unexpected and reproducible misbehavior.

Comments

@rajohns08
Copy link

I've tried adding multiple ending new lines and having 0 extra new lines at the end of my file, but I never get a warning for this. I know the swiftlint library is active though, because I'm getting other warnings.
@jpsim jpsim mentioned this issue May 28, 2015
Merged
@jpsim jpsim added the bug Unexpected and reproducible misbehavior. label May 28, 2015
@jpsim
Copy link
Collaborator

jpsim commented May 28, 2015

You're absolutely right! I'll look into why this is the case.

jpsim added a commit that referenced this issue May 28, 2015
@jpsim
Trailing newline & file length violations are now displayed in Xcode: f…
26075a2 
…ixes #43
@jpsim jpsim mentioned this issue May 28, 2015
Merged
@jpsim jpsim closed this as completed in #46 May 28, 2015
@jpsim
Copy link
Collaborator

jpsim commented May 28, 2015

The problem was that we weren't specifying a line in the warning, so Xcode didn't pick it up. Fixed in #46.

@rajohns08
Copy link
Author

Has this fix been pushed to brew yet? Running a brew upgrade didn't update the package.

@jpsim
Copy link
Collaborator

jpsim commented May 28, 2015

Nope, there's a big pile of fixes as you can see from the CHANGELOG that I'd like to include in a release shortly. I'll cut a release today or tomorrow.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Unexpected and reproducible misbehavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Trailing newline & file length violations are now displayed in Xcode realm/SwiftLint
2 participants
@jpsim @rajohns08