Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TypeNameRuleExamples: added test to verify that enum cases are lowercase in Swift 3 #1115

Closed
wants to merge 1 commit into from

Conversation

NachoSoto
Copy link
Contributor

To my surprise, the type_name rule is not currently validating this. I've found some issues referring to this (#655, #654, #663, and the change in #660), but it's not clear to me whether not validating this was on purpose.

So I figured I'd ask this question by sending the failing test. I'd love to have this rule validate this, but I wonder if there's a reason why this was not enabled.

Thanks.

…ase in Swift 3

To my surprise, the `type_name` rule is not currently validating this. I've found some issues referring to this (realm#655, realm#654, realm#663, and the change in realm#660),
but it's not clear to me whether not validating this was on purpose.
@marcelofabri
Copy link
Collaborator

marcelofabri commented Jan 4, 2017

This will actually be fixed by #954. You can see the a similar test here: https://github.com/realm/SwiftLint/pull/954/files#diff-eb77d039fb569db405aad5349c41349aR47

That took a while because we wanted to make sure to have a deprecation warning and not just break old configurations, which is now possible thanks to #974.

@jpsim
Copy link
Collaborator

jpsim commented Jan 5, 2017

Closing in favor of #954.

@jpsim jpsim closed this Jan 5, 2017
@NachoSoto NachoSoto deleted the enum-upper-case branch January 5, 2017 21:52
@NachoSoto
Copy link
Contributor Author

Awesome, thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants