Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix a false positive on large_tuple rule #1235

Merged
merged 1 commit into from
Jan 24, 2017
Merged

Fix a false positive on large_tuple rule #1235

merged 1 commit into from
Jan 24, 2017

Conversation

marcelofabri
Copy link
Collaborator

Fixes #1234

@SwiftLintBot
Copy link

SwiftLintBot commented Jan 23, 2017

42 Messages
📖 Linting WordPress-iOS with this PR took 7.17s vs 9.48s on master (24% faster)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L47:10: error: Large Tuple Violation: Tuples should have at most 3 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L51:10: error: Large Tuple Violation: Tuples should have at most 3 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L54:10: warning: Large Tuple Violation: Tuples should have at most 2 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L58:10: error: Large Tuple Violation: Tuples should have at most 3 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L65:10: warning: Large Tuple Violation: Tuples should have at most 2 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L68:10: error: Large Tuple Violation: Tuples should have at most 3 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L71:10: warning: Large Tuple Violation: Tuples should have at most 2 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L76:10: warning: Large Tuple Violation: Tuples should have at most 2 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L80:10: error: Large Tuple Violation: Tuples should have at most 3 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L83:10: warning: Large Tuple Violation: Tuples should have at most 2 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L86:10: warning: Large Tuple Violation: Tuples should have at most 2 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L89:10: warning: Large Tuple Violation: Tuples should have at most 2 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L93:10: error: Large Tuple Violation: Tuples should have at most 3 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L98:10: warning: Large Tuple Violation: Tuples should have at most 2 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L101:10: error: Large Tuple Violation: Tuples should have at most 3 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L104:10: error: Large Tuple Violation: Tuples should have at most 3 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L145:10: error: Large Tuple Violation: Tuples should have at most 3 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L145:10: error: Large Tuple Violation: Tuples should have at most 3 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/TaskDelegate.swift#L73:5: error: Large Tuple Violation: Tuples should have at most 3 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/TaskDelegate.swift#L74:5: warning: Large Tuple Violation: Tuples should have at most 2 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/SessionDelegate.swift#L39:10: error: Large Tuple Violation: Tuples should have at most 3 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/TaskDelegate.swift#L218:5: warning: Large Tuple Violation: Tuples should have at most 2 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/TaskDelegate.swift#L219:5: warning: Large Tuple Violation: Tuples should have at most 2 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/TaskDelegate.swift#L220:5: warning: Large Tuple Violation: Tuples should have at most 2 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/TaskDelegate.swift#L221:5: warning: Large Tuple Violation: Tuples should have at most 2 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/TaskDelegate.swift#L326:5: warning: Large Tuple Violation: Tuples should have at most 2 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/TaskDelegate.swift#L327:5: error: Large Tuple Violation: Tuples should have at most 3 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/TaskDelegate.swift#L328:5: error: Large Tuple Violation: Tuples should have at most 3 members. (large_tuple)
📖 This PR fixed a violation in Alamofire: /Source/TaskDelegate.swift#L431:5: error: Large Tuple Violation: Tuples should have at most 3 members. (large_tuple)
📖 Linting Alamofire with this PR took 3.17s vs 3.24s on master (2% faster)
📖 Linting swift with this PR took 10.75s vs 11.6s on master (7% faster)
📖 Linting Aerial with this PR took 0.4s vs 0.49s on master (18% faster)
📖 Linting SourceKitten with this PR took 1.36s vs 1.68s on master (19% faster)
📖 Linting Sourcery with this PR took 2.09s vs 2.48s on master (15% faster)
📖 Linting ios-oss with this PR took 16.2s vs 20.63s on master (21% faster)
📖 Linting Moya with this PR took 0.43s vs 0.56s on master (23% faster)
📖 Linting firefox-ios with this PR took 15.22s vs 20.11s on master (24% faster)
📖 Linting Nimble with this PR took 1.71s vs 2.21s on master (22% faster)
📖 Linting Quick with this PR took 0.49s vs 0.65s on master (24% faster)
📖 Linting realm-cocoa with this PR took 2.45s vs 3.17s on master (22% faster)
📖 This PR fixed a violation in Alamofire: /Source/TaskDelegate.swift#L76:5: warning: Large Tuple Violation: Tuples should have at most 2 members. (large_tuple)

Generated by 🚫 danger

Copy link
Collaborator

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍. This seems to also be an significant performance improvement, if the numbers from OSSCheck are to be believed!

@marcelofabri marcelofabri merged commit 1ad1fd2 into realm:master Jan 24, 2017
@marcelofabri marcelofabri deleted the bugfix_1234 branch January 24, 2017 00:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants