Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add for_where rule #1260

Closed
wants to merge 1 commit into from
Closed

Add for_where rule #1260

wants to merge 1 commit into from

Conversation

marcelofabri
Copy link
Collaborator

Fixes #1228

@SwiftLintBot
Copy link

SwiftLintBot commented Jan 29, 2017

2 Warnings
⚠️ This PR introduced a violation in swift: /stdlib/public/core/EmptyCollection.swift#L147:10: warning: Missing Docs Violation: Public declarations should be documented. (missing_docs)
⚠️ This PR introduced a violation in firefox-ios: /Storage/SQL/SQLiteRemoteClientsAndTabs.swift#L340:12: warning: Missing Docs Violation: Public declarations should be documented. (missing_docs)
14 Messages
📖 Linting WordPress-iOS with this PR took 16.02s vs 15.52s on master (3% slower)
📖 This PR fixed a violation in Nimble: /Sources/Nimble/Matchers/MatcherFunc.swift#L54:12: warning: Missing Docs Violation: Public declarations should be documented. (missing_docs)
📖 Linting Alamofire with this PR took 3.91s vs 4.54s on master (13% faster)
📖 Linting swift with this PR took 14.31s vs 16.17s on master (11% faster)
📖 Linting Aerial with this PR took 0.65s vs 0.58s on master (12% slower)
📖 Linting SourceKitten with this PR took 1.69s vs 1.89s on master (10% faster)
📖 Linting Sourcery with this PR took 3.0s vs 3.34s on master (10% faster)
📖 This PR fixed a violation in Nimble: /Sources/Nimble/Matchers/MatcherFunc.swift#L46:12: warning: Missing Docs Violation: Public declarations should be documented. (missing_docs)
📖 Linting Moya with this PR took 0.57s vs 0.59s on master (3% faster)
📖 Linting firefox-ios with this PR took 24.72s vs 24.76s on master (0% faster)
📖 Linting Nimble with this PR took 2.52s vs 2.27s on master (11% slower)
📖 Linting Quick with this PR took 0.75s vs 0.73s on master (2% slower)
📖 Linting realm-cocoa with this PR took 3.93s vs 3.67s on master (7% slower)
📖 Linting ios-oss with this PR took 21.12s vs 23.86s on master (11% faster)

Generated by 🚫 danger

@codecov-io
Copy link

Current coverage is 82.00% (diff: 93.02%)

Merging #1260 into master will increase coverage by 0.05%

@@             master      #1260   diff @@
==========================================
  Files           168        169     +1   
  Lines          8341       8384    +43   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           6835       6875    +40   
- Misses         1506       1509     +3   
  Partials          0          0          

Powered by Codecov. Last update 118e387...c616d80

@jpsim
Copy link
Collaborator

jpsim commented Jan 30, 2017

Isn't it odd that OSSCheck didn't uncover any violations of this?

@marcelofabri
Copy link
Collaborator Author

Isn't it odd that OSSCheck didn't uncover any violations of this?

I think it's because of #1248

@jpsim
Copy link
Collaborator

jpsim commented Feb 9, 2017

Merged in f0c8fba. Thanks!

@jpsim jpsim closed this Feb 9, 2017
@marcelofabri marcelofabri deleted the for_where_rule branch February 14, 2017 14:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants