Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merge master before running OSSCheck on branch #1494

Merged
merged 1 commit into from
May 4, 2017
Merged

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented May 4, 2017

To avoid the branch build being so out of date that OSSCheck reports unrelated differences, which is what happened #1489 (comment) for example.

@SwiftLintBot
Copy link

12 Messages
📖 Linting WordPress with this PR took 15.13s vs 12.96s on master (16% slower)
📖 Linting Alamofire with this PR took 3.44s vs 3.46s on master (0% faster)
📖 Linting Firefox with this PR took 16.26s vs 15.07s on master (7% slower)
📖 Linting Kickstarter with this PR took 21.67s vs 19.34s on master (12% slower)
📖 Linting Moya with this PR took 0.5s vs 0.42s on master (19% slower)
📖 Linting Nimble with this PR took 2.05s vs 2.0s on master (2% slower)
📖 Linting Aerial with this PR took 0.44s vs 0.49s on master (10% faster)
📖 Linting Realm with this PR took 3.09s vs 3.34s on master (7% faster)
📖 Linting SourceKitten with this PR took 1.27s vs 1.29s on master (1% faster)
📖 Linting Sourcery with this PR took 3.36s vs 3.49s on master (3% faster)
📖 Linting Swift with this PR took 14.5s vs 13.75s on master (5% slower)
📖 Linting Quick with this PR took 0.61s vs 0.63s on master (3% faster)

Generated by 🚫 danger

@jpsim jpsim merged commit fe4a199 into master May 4, 2017
@jpsim jpsim deleted the jp-osscheck-merge branch May 4, 2017 22:20
@codecov-io
Copy link

Codecov Report

Merging #1494 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1494   +/-   ##
=======================================
  Coverage   83.14%   83.14%           
=======================================
  Files         180      180           
  Lines        9063     9063           
=======================================
  Hits         7535     7535           
  Misses       1528     1528

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd3fe63...b65a40c. Read the comment docs.

@marcelofabri
Copy link
Collaborator

Maybe this had unexpected consequences? I've rebased #1484 and #1478 and none of them are showing violations any more 😬

@jpsim
Copy link
Collaborator Author

jpsim commented May 8, 2017

Yeah, that's weird. I'll revert and if irrelevant regressions/fixes show up in the future, we'll just ask PR authors to rebase until we can address in a way that doesn't break this functionality 😬.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants