Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Skip files with valid cache & no violations when auto correcting #1579

Merged
merged 1 commit into from
May 28, 2017
Merged

Skip files with valid cache & no violations when auto correcting #1579

merged 1 commit into from
May 28, 2017

Conversation

marcelofabri
Copy link
Collaborator

Fixes #1554

@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 0.35s vs 0.33s on master (6% slower)
📖 Linting Alamofire with this PR took 2.18s vs 2.15s on master (1% slower)
📖 Linting Firefox with this PR took 9.46s vs 9.33s on master (1% slower)
📖 Linting Kickstarter with this PR took 12.38s vs 12.18s on master (1% slower)
📖 Linting Moya with this PR took 0.66s vs 0.65s on master (1% slower)
📖 Linting Nimble with this PR took 1.21s vs 1.24s on master (2% faster)
📖 Linting Quick with this PR took 0.4s vs 0.41s on master (2% faster)
📖 Linting Realm with this PR took 1.89s vs 1.86s on master (1% slower)
📖 Linting SourceKitten with this PR took 0.83s vs 0.85s on master (2% faster)
📖 Linting Sourcery with this PR took 1.95s vs 1.95s on master (0% slower)
📖 Linting Swift with this PR took 8.6s vs 8.74s on master (1% faster)
📖 Linting WordPress with this PR took 9.19s vs 9.13s on master (0% slower)

Generated by 🚫 Danger

@codecov-io
Copy link

codecov-io commented May 28, 2017

Codecov Report

Merging #1579 into master will decrease coverage by 0.09%.
The diff coverage is 5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1579     +/-   ##
=========================================
- Coverage   84.33%   84.23%   -0.1%     
=========================================
  Files         192      192             
  Lines        9961     9974     +13     
=========================================
+ Hits         8401     8402      +1     
- Misses       1560     1572     +12
Impacted Files Coverage Δ
...iftlint/Extensions/Configuration+CommandLine.swift 0% <0%> (ø) ⬆️
Source/swiftlint/Commands/AutoCorrectCommand.swift 0% <0%> (ø) ⬆️
Source/SwiftLintFramework/Models/Linter.swift 71.26% <33.33%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c0cf07...3395523. Read the comment docs.

Copy link
Collaborator

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks right to me

@marcelofabri marcelofabri merged commit fc5e610 into realm:master May 28, 2017
@marcelofabri marcelofabri deleted the autocorrect-cache branch May 28, 2017 15:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants