Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add private_over_fileprivate and strict_fileprivate rules #1656

Merged
merged 5 commits into from
Jul 4, 2017
Merged

Add private_over_fileprivate and strict_fileprivate rules #1656

merged 5 commits into from
Jul 4, 2017

Conversation

marcelofabri
Copy link
Collaborator

Continued from #1489. Adds private_over_fileprivate correctable rule and strict_fileprivate opt-in rule.

Fixes #1469, #1058

// cc @masters3d

@marcelofabri
Copy link
Collaborator Author

In the end, I think it's better to go with two different rules so it's easier to understand what each of them validates (with examples).

@SwiftLintBot
Copy link

5916 Warnings
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/Preferences.swift#L16:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/Preferences.swift#L116:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/Preferences.swift#L121:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/Preferences.swift#L126:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/Preferences.swift#L132:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/PreferencesWindowController.swift#L112:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Alamofire: /Source/ParameterEncoding.swift#L435:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Alamofire: /Source/Validation.swift#L31:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Alamofire: /Source/Validation.swift#L42:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Alamofire: /Source/Validation.swift#L75:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Alamofire: /Source/Validation.swift#L77:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Alamofire: /Source/Validation.swift#L87:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Alamofire: /Source/Validation.swift#L103:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Alamofire: /Tests/RequestTests.swift#L385:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Alamofire: /Tests/RequestTests.swift#L393:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FxADevice.swift#L22:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FirefoxAccount.swift#L39:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FirefoxAccount.swift#L47:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FirefoxAccount.swift#L48:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FirefoxAccount.swift#L92:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FirefoxAccount.swift#L149:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FxADeviceRegistration.swift#L147:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FxADeviceRegistration.swift#L165:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FxADeviceRegistration.swift#L177:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FxAClient10.swift#L143:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FxAClient10.swift#L159:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FxAClient10.swift#L172:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FxAClient10.swift#L208:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FxAClient10.swift#L217:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FxAClient10.swift#L226:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FxAClient10.swift#L239:10: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FxAClient10.swift#L309:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FxALoginStateMachine.swift#L45:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FxALoginStateMachine.swift#L179:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FxAPushMessageHandler.swift#L160:1: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
⚠️ This PR introduced a violation in Firefox: /Account/FxAPushMessageHandler.swift#L160:1: warning: Private over fileprivate Violation: Prefer private over fileprivate declarations. (private_over_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/FxAPushMessageHandler.swift#L160:1: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/HawkHelper.swift#L10:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/SyncAuthState.swift#L54:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/SyncAuthState.swift#L55:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/SyncAuthState.swift#L73:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/TokenServerClient.swift#L101:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/TokenServerClient.swift#L109:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/TokenServerClient.swift#L120:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Account/TokenServerClient.swift#L139:10: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AdjustIntegration.swift#L45:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AdjustIntegration.swift#L61:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AdjustIntegration.swift#L79:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AdjustIntegration.swift#L87:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AdjustIntegration.swift#L96:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AdjustIntegration.swift#L109:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AdjustIntegration.swift#L119:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/LeanplumIntegration.swift#L67:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/LeanplumIntegration.swift#L80:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/QuickActions.swift#L33:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/QuickActions.swift#L41:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/QuickActions.swift#L42:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/QuickActions.swift#L104:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/QuickActions.swift#L119:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/QuickActions.swift#L123:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/WebServer.swift#L30:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Extensions/NSURLExtensionsMailTo.swift#L16:1: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
⚠️ This PR introduced a violation in Firefox: /Client/Extensions/UIPasteboardExtensions.swift#L21:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Extensions/UIImageViewExtensions.swift#L10:1: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
⚠️ This PR introduced a violation in Firefox: /Client/Extensions/UIImageViewExtensions.swift#L94:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Accessors/HomePageAccessors.swift#L13:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Animators/JumpAndSpinAnimator.swift#L8:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Animators/JumpAndSpinAnimator.swift#L9:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/BasePasscodeViewController.swift#L40:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/ChangePasscodeViewController.swift#L13:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/ChangePasscodeViewController.swift#L14:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/ChangePasscodeViewController.swift#L87:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/PagingPasscodeViewController.swift#L10:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AppDelegate.swift#L67:24: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AppDelegate.swift#L494:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AppDelegate.swift#L519:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AppDelegate.swift#L542:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AppDelegate.swift#L548:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AppDelegate.swift#L569:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AppDelegate.swift#L578:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AppDelegate.swift#L597:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AppDelegate.swift#L642:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AppDelegate.swift#L683:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AppDelegate.swift#L691:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AppDelegate.swift#L703:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/PasscodeEntryViewController.swift#L19:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/RemovePasscodeViewController.swift#L51:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift#L79:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift#L133:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift#L147:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift#L149:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift#L150:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift#L152:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift#L153:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift#L191:11: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift#L245:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift#L253:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift#L292:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift#L323:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/RequirePasscodeIntervalViewController.swift#L20:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/RequirePasscodeIntervalViewController.swift#L21:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/SetupPasscodeViewController.swift#L13:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/SetupPasscodeViewController.swift#L63:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/SensitiveViewController.swift#L87:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/PasscodeViews.swift#L29:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/PasscodeViews.swift#L31:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/PasscodeViews.swift#L33:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/PasscodeViews.swift#L37:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/PasscodeViews.swift#L122:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/PasscodeViews.swift#L129:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BackForwardListAnimator.swift#L48:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/Authenticator.swift#L15:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/Authenticator.swift#L100:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BackForwardListViewController.swift#L19:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BackForwardListViewController.swift#L20:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BackForwardListViewController.swift#L21:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BackForwardListViewController.swift#L22:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BackForwardListViewController.swift#L23:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BackForwardListViewController.swift#L24:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BackForwardListViewController.swift#L25:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/ButtonToast.swift#L31:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/ButtonToast.swift#L32:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/ButtonToast.swift#L33:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/ButtonToast.swift#L38:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/ButtonToast.swift#L39:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/ButtonToast.swift#L65:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/ButtonToast.swift#L126:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/CustomSearchHandler.swift#L9:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/ContextMenuHelper.swift#L12:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/ContextMenuHelper.swift#L14:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/ContextMenuHelper.swift#L15:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/ContextMenuHelper.swift#L29:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L21:1: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L108:1: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/FindInPageBar.swift#L26:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/FindInPageBar.swift#L27:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
⚠️ Danger found 5916 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 136.
275 Messages
📖 Linting Aerial with this PR took 0.36s vs 0.33s on master (9% slower)
📖 Linting Alamofire with this PR took 2.38s vs 2.4s on master (0% faster)
📖 This PR fixed a violation in Firefox: /Account/FxAPushMessageHandler.swift#L160:13: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Client/Extensions/NSURLExtensionsMailTo.swift#L16:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Client/Extensions/UIImageViewExtensions.swift#L10:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L21:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L108:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/SearchViewController.swift#L587:13: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/TabScrollController.swift#L155:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/BrowserViewController.swift#L3489:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Client/Frontend/# Management/#ListViewController.swift#L23:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Client/Frontend/# Management/#ListViewController.swift#L192:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Notifications/NotificationRootViewController.swift#L181:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Notifications/NotificationRootViewController.swift#L213:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Share/ShareExtensionHelper.swift#L114:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Widgets/Menu/Items/MenuItemView.swift#L72:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Widgets/Menu/MenuViewController.swift#L358:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Push/PushClient.swift#L90:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Push/PushRegistration.swift#L120:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Shared/AuthenticationKeychainInfo.swift#L22:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Shared/AuthenticationKeychainInfo.swift#L90:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Shared/Extensions/AlamofireExtensions.swift#L8:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Shared/Extensions/DataExtensions.swift#L7:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Shared/Extensions/ArrayExtensions.swift#L7:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Shared/Extensions/ArrayExtensions.swift#L54:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Shared/Extensions/JSONExtensions.swift#L8:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Shared/Extensions/KeychainWrapperExtensions.swift#L8:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Shared/Extensions/NSFileManagerExtensions.swift#L18:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Shared/Extensions/SetExtensions.swift#L7:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Shared/Extensions/SetExtensions.swift#L32:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Shared/Extensions/URLRequestExtensions.swift#L7:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Shared/Extensions/StringExtensions.swift#L7:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Shared/Functions.swift#L111:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Shared/Extensions/NSURLExtensions.swift#L396:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Shared/Logger.swift#L11:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Storage/Bookmarks/BookmarksModel.swift#L256:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Storage/SQL/SQLiteBookmarksSyncing.swift#L303:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Storage/SQL/SQLiteBookmarksSyncing.swift#L944:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Firefox: /Telemetry/Events.swift#L11:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 Linting Firefox with this PR took 10.38s vs 10.44s on master (0% faster)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Library/MFMailComposeViewController.swift#L6:10: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /KsApi/lib/Decodable.swift#L3:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /KsApi/extensions/NSURLSession.swift#L15:10: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /KsApi/lib/EncodableType.swift#L11:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /KsApi/MockService.swift#L1149:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /KsApi/Service.swift#L7:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/DataSource/UICollectionView-Extensions.swift#L3:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/DataSource/UITableView-Extensions.swift#L3:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/ExpandableRow.swift#L28:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/Koala/TrackingClientType.swift#L11:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/RootCategory.swift#L25:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/SelectableRow.swift#L22:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/String+SimpleHTML.swift#L4:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/SimpleHTMLLabel.swift#L194:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/UIBarButtonItem.swift#L4:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/UIButton+LocalizedKey.swift#L3:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/UIColor.swift#L5:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/UIGestureRecognizer-Extensions.swift#L3:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/UILabel+IBClear.swift#L3:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/UILabel+IsTruncated.swift#L3:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/UILabel+LocalizedKey.swift#L3:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/UILabel+SimpleHTML.swift#L3:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/UIPress-Extensions.swift#L3:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/UIAlertController.swift#L7:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/UINavigationItem+Localized.swift#L3:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/UITextField+LocalizedPlaceholderKey.swift#L3:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/CheckoutViewModelTests.swift#L1033:10: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /LiveStream/Models/LiveStreamChatMessage.swift#L12:10: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Kickstarter: /LiveStream/Models/LiveStreamEventTests.swift#L6:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 Linting Kickstarter with this PR took 14.9s vs 14.88s on master (0% slower)
📖 This PR fixed a violation in Moya: /Sources/Moya/MoyaError.swift#L24:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Moya: /Sources/Moya/MoyaProvider+Defaults.swift#L5:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Moya: /Sources/Moya/Plugin.swift#L24:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Moya: /Sources/Moya/MoyaProvider.swift#L129:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Moya: /Sources/Moya/TargetType.swift#L32:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Moya: /Sources/Moya/Response.swift#L35:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Moya: /Sources/Moya/Plugins/NetworkLoggerPlugin.swift#L53:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Moya: /Sources/Moya/Plugins/NetworkLoggerPlugin.swift#L107:13: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Moya: /Sources/Moya/MoyaProvider+Internal.swift#L20:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Moya: /Sources/Moya/MoyaProvider+Internal.swift#L149:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Moya: /Sources/Moya/MoyaProvider+Internal.swift#L261:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Moya: /Sources/ReactiveMoya/ReactiveSwiftMoyaProvider.swift#L67:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Moya: /Sources/RxMoya/RxMoyaProvider.swift#L41:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 Linting Moya with this PR took 0.67s vs 0.67s on master (0% slower)
📖 Linting Nimble with this PR took 1.34s vs 1.31s on master (2% slower)
📖 This PR fixed a violation in Quick: /Sources/Quick/NSString+C99ExtendedIdentifier.swift#L4:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Quick: /Tests/QuickTests/QuickTestHelpers/XCTestCaseProvider.swift#L25:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 Linting Quick with this PR took 0.43s vs 0.43s on master (0% slower)
📖 This PR fixed a violation in Realm: /RealmSwift/Sync.swift#L115:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Realm: /RealmSwift/Sync.swift#L651:13: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Realm: /RealmSwift/Sync.swift#L665:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 Linting Realm with this PR took 2.1s vs 2.07s on master (1% slower)
📖 This PR fixed a violation in SourceKitten: /Source/SourceKittenFramework/CodeCompletionItem.swift#L11:13: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in SourceKitten: /Source/SourceKittenFramework/library_wrapper.swift#L131:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in SourceKitten: /Source/SourceKittenFramework/File.swift#L455:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L120:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 Linting SourceKitten with this PR took 0.87s vs 0.87s on master (0% slower)
📖 This PR fixed a violation in Sourcery: /Sourcery/Generating/Template/Swift/SwiftTemplate.swift#L209:13: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Sourcery: /Sourcery/Generating/Template/Swift/SwiftTemplate.swift#L220:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Sourcery: /Sourcery/Generating/Template/Swift/SwiftTemplate.swift#L232:9: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Sourcery: /SourceryRuntime/Sources/Extensions.swift#L3:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Sourcery: /SourceryRuntime/Sources/Extensions.swift#L186:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 Linting Sourcery with this PR took 2.84s vs 2.81s on master (1% slower)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Mirror.swift#L495:10: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/SDK/AppKit/AppKit.swift#L54:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/SDK/AppKit/AppKit_FoundationExtensions.swift#L17:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/SDK/AppKit/AppKit_FoundationExtensions.swift#L54:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L2567:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3707:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3714:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3725:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3732:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3743:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3750:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3761:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3768:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3779:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3786:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3797:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3804:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3815:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3822:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3833:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3840:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3851:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3858:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3869:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3876:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3887:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3894:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3905:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3912:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3923:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3930:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3941:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L3948:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L4205:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L4212:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L4290:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L4368:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift#L4465:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/SDK/Dispatch/Dispatch.swift#L132:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/SDK/Dispatch/Dispatch.swift#L162:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/SDK/CoreGraphics/CoreGraphics.swift#L204:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
📖 This PR fixed a violation in Swift: /stdlib/public/SDK/CoreGraphics/CoreGraphics.swift#L268:8: error: No Extension Access Modifier Violation: Prefer not to use extension access modifiers (no_extension_access_modifier)
⚠️ Danger found 275 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 145.

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #1656 into master will increase coverage by 0.05%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1656      +/-   ##
=========================================
+ Coverage   87.25%   87.3%   +0.05%     
=========================================
  Files         198     200       +2     
  Lines        9840    9887      +47     
=========================================
+ Hits         8586    8632      +46     
- Misses       1254    1255       +1
Impacted Files Coverage Δ
.../SwiftLintFramework/Rules/IdentifierNameRule.swift 93.75% <ø> (ø) ⬆️
...s/SwiftLintFrameworkTests/ConfigurationTests.swift 94.38% <ø> (ø) ⬆️
...sts/SwiftLintFrameworkTests/LinterCacheTests.swift 99.05% <ø> (ø) ⬆️
...ramework/Rules/NoExtensionAccessModifierRule.swift 86.66% <100%> (ø)
Tests/SwiftLintFrameworkTests/RulesTests.swift 100% <100%> (ø) ⬆️
...iftLintFramework/Rules/StrictFilePrivateRule.swift 100% <100%> (ø)
...ntFramework/Rules/PrivateOverFilePrivateRule.swift 94.59% <94.59%> (ø)
...SwiftLintFramework/Models/AccessControlLevel.swift 78.94% <0%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85cdcbe...2c221b0. Read the comment docs.

@masters3d
Copy link
Contributor

Good call.

@marcelofabri marcelofabri merged commit dab9e39 into realm:master Jul 4, 2017
@marcelofabri marcelofabri deleted the fileprivate-rule branch July 4, 2017 08:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants