Fix mark rule corrections generating invalid code in some cases
#1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, we never invalidated the file cache when autocorrecting π¬
Generated by π« Danger |
Codecov Report
@@ Coverage Diff @@
## master #1706 +/- ##
=========================================
+ Coverage 87.37% 87.4% +0.02%
=========================================
Files 205 205
Lines 10146 10146
=========================================
+ Hits 8865 8868 +3
+ Misses 1281 1278 -3
Continue to review full report at Codecov.
|
|
Nice catch, nice fix, π , just a typo: |
|
nice catch on that typo π΅οΈ |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, we never invalidated the file cache when autocorrecting π¬
Fixes #1029 (finally!).