Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add untyped_error_in_catch opt-in rule #2101

Merged
merged 5 commits into from
Mar 17, 2018
Merged

Add untyped_error_in_catch opt-in rule #2101

merged 5 commits into from
Mar 17, 2018

Conversation

marcelofabri
Copy link
Collaborator

Continued from #2055.

@SwiftLintBot
Copy link

SwiftLintBot commented Mar 17, 2018

38 Warnings
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:52:19: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:168:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:169:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Application/AdjustIntegration.swift:150:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Application/AdjustIntegration.swift:166:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Providers/Profile.swift:1070:15: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Shared/SentryIntegration.swift:77:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/SyncTelemetry/SyncPingCentre.swift:98:19: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/SyncTelemetry/SyncPingCentre.swift:116:19: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/SyncTelemetry/SyncTelemetryEvents.swift:66:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/SyncTelemetry/SyncTelemetryEvents.swift:83:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/Synchronizers/Bookmarks/ThreeWayTreeMerger.swift:1053:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/Service.swift:524:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Moya: /Users/distiller/project/osscheck/Moya/Sources/Moya/Response.swift:168:19: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Moya: /Users/distiller/project/osscheck/Moya/Sources/Moya/Response.swift:184:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/project/osscheck/Nimble/Sources/Nimble/Adapters/NMBObjCMatcher.swift:51:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/project/osscheck/Nimble/Sources/Nimble/DSL+Wait.swift:62:27: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/project/osscheck/Nimble/Sources/Nimble/Expectation.swift:15:7: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/project/osscheck/Nimble/Sources/Nimble/Expectation.swift:33:7: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/project/osscheck/Nimble/Sources/Nimble/Expectation.swift:51:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/project/osscheck/Nimble/Sources/Nimble/Matchers/ThrowAssertion.swift:30:15: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/project/osscheck/Nimble/Sources/Nimble/Matchers/ThrowError.swift:20:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/project/osscheck/Nimble/Sources/Nimble/Matchers/ThrowError.swift:51:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/project/osscheck/Nimble/Sources/Nimble/Matchers/ThrowError.swift:96:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/project/osscheck/Nimble/Sources/Nimble/Matchers/ThrowError.swift:144:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/project/osscheck/Nimble/Sources/Nimble/Matchers/ThrowError.swift:203:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/project/osscheck/Nimble/Sources/Nimble/Matchers/ThrowError.swift:238:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/project/osscheck/Nimble/Sources/Nimble/Utils/Async.swift:260:15: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/project/osscheck/Nimble/Sources/Nimble/Utils/Async.swift:344:19: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Realm: /Users/distiller/project/osscheck/Realm/RealmSwift/Realm.swift:156:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/project/osscheck/Swift/stdlib/public/SDK/Dispatch/Queue.swift:239:7: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/project/osscheck/Swift/stdlib/public/SDK/Dispatch/Queue.swift:263:6: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/project/osscheck/Swift/stdlib/public/SDK/Foundation/IndexSet.swift:591:19: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/project/osscheck/Swift/stdlib/public/SDK/Foundation/PlistEncoder.swift:495:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in WordPress: /Users/distiller/project/osscheck/WordPress/WordPress/Classes/Services/InAppPurchaseStore.swift:241:19: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in WordPress: /Users/distiller/project/osscheck/WordPress/WordPress/Classes/ViewRelated/Views/WPRichText/WPRichContentView.swift:145:15: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in WordPress: /Users/distiller/project/osscheck/WordPress/WordPress/WordPressScreenshotGeneration/SnapshotHelper.swift:76:11: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
⚠️ This PR introduced a violation in WordPress: /Users/distiller/project/osscheck/WordPress/WordPress/WordPressScreenshotGeneration/SnapshotHelper.swift:142:15: warning: Untyped Error in Catch Violation: warning (untyped_error_in_catch)
12 Messages
📖 Linting Aerial with this PR took 0.51s vs 0.43s on master (18% slower)
📖 Linting Alamofire with this PR took 3.72s vs 3.56s on master (4% slower)
📖 Linting Firefox with this PR took 14.99s vs 14.59s on master (2% slower)
📖 Linting Kickstarter with this PR took 22.6s vs 21.93s on master (3% slower)
📖 Linting Moya with this PR took 2.04s vs 2.09s on master (2% faster)
📖 Linting Nimble with this PR took 1.97s vs 2.02s on master (2% faster)
📖 Linting Quick with this PR took 0.59s vs 0.61s on master (3% faster)
📖 Linting Realm with this PR took 3.94s vs 3.96s on master (0% faster)
📖 Linting SourceKitten with this PR took 1.23s vs 1.32s on master (6% faster)
📖 Linting Sourcery with this PR took 5.16s vs 5.31s on master (2% faster)
📖 Linting Swift with this PR took 15.01s vs 15.57s on master (3% faster)
📖 Linting WordPress with this PR took 17.36s vs 17.92s on master (3% faster)

Generated by 🚫 Danger

@codecov-io
Copy link

codecov-io commented Mar 17, 2018

Codecov Report

Merging #2101 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2101      +/-   ##
==========================================
+ Coverage   89.69%   89.71%   +0.02%     
==========================================
  Files         260      261       +1     
  Lines       15027    15042      +15     
  Branches      978      978              
==========================================
+ Hits        13478    13495      +17     
+ Misses       1532     1530       -2     
  Partials       17       17
Impacted Files Coverage Δ
...tLintFramework/Rules/UntypedErrorInCatchRule.swift 100% <100%> (ø)
Tests/SwiftLintFrameworkTests/RulesTests.swift 100% <100%> (ø) ⬆️
Source/SwiftLintFramework/Models/Command.swift 97.82% <0%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2c4302...bbe2923. Read the comment docs.

@marcelofabri marcelofabri merged commit 63bad0d into realm:master Mar 17, 2018
@marcelofabri marcelofabri deleted the untype-error-in-catch branch March 17, 2018 22:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants