Fix false positives on rule unused_closure_parameter with self arguments
#2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Source/SwiftLintFramework/Rules/Lint/UnusedClosureParameterRule.swift
Outdated
Show resolved
Hide resolved
Jeehut
added a commit
that referenced
this pull request
Feb 12, 2019
…ntial issues This was suggested by @[marcelofabri](/marcelofabri) here: #2639 (comment)
marcelofabri
approved these changes
Feb 12, 2019
|
@Dschee feel free to merge this after the conflict is resolved |
…nd handle like identifier Rationale: This makes the usage of the Delegated pattern usable without violating this rule. See here for more details: https://github.com/dreymonde/Delegated
…ntial issues This was suggested by @[marcelofabri](/marcelofabri) here: #2639 (comment)
Jeehut
force-pushed
the
cg-unused_closure_parameter-fix
branch
from
a5641a7 to
4622b20
Compare
sjavora
pushed a commit
to sjavora/SwiftLint
that referenced
this pull request
Mar 9, 2019
…ntial issues This was suggested by @[marcelofabri](/marcelofabri) here: realm#2639 (comment)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2437.