Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix "superfluous_disable_command" / "disable all" interference #2716

Merged

Conversation

fredpi
Copy link
Collaborator

@fredpi fredpi commented Apr 12, 2019

Closes #2670.

@SwiftLintBot
Copy link

SwiftLintBot commented Apr 12, 2019

12 Messages
📖 Linting Aerial with this PR took 2.06s vs 2.2s on master (6% faster)
📖 Linting Alamofire with this PR took 4.73s vs 5.22s on master (9% faster)
📖 Linting Firefox with this PR took 13.57s vs 15.81s on master (14% faster)
📖 Linting Kickstarter with this PR took 23.62s vs 25.46s on master (7% faster)
📖 Linting Moya with this PR took 2.18s vs 2.25s on master (3% faster)
📖 Linting Nimble with this PR took 1.93s vs 1.89s on master (2% slower)
📖 Linting Quick with this PR took 0.63s vs 0.59s on master (6% slower)
📖 Linting Realm with this PR took 4.57s vs 3.94s on master (15% slower)
📖 Linting SourceKitten with this PR took 1.28s vs 1.54s on master (16% faster)
📖 Linting Sourcery with this PR took 4.7s vs 5.46s on master (13% faster)
📖 Linting Swift with this PR took 28.26s vs 29.95s on master (5% faster)
📖 Linting WordPress with this PR took 24.85s vs 26.22s on master (5% faster)

Generated by 🚫 Danger

Copy link
Collaborator

@marcelofabri marcelofabri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only had one nitpick, but it looks good! Thanks, @fredpi 🚀

@marcelofabri
Copy link
Collaborator

@fredpi Thanks for the quick update, will merge it once it's green ✅

@marcelofabri marcelofabri merged commit c80ffd3 into realm:master Apr 12, 2019
@fredpi fredpi deleted the feature/#2670-fix-superfluous-disable branch April 12, 2019 17:08
@jpsim
Copy link
Collaborator

jpsim commented Apr 14, 2019

💯

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

superfluous_disable_command overrides disable all
4 participants