Add valid_docs rule handle multibyte characters. #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,6 +16,10 @@ | |||
| [JP Simard](https://github.com/jpsim) | |||
| [#279](https://github.com/realm/SwiftLint/issues/279) | |||
|
|
|||
| * valid_docs rule doesn't handle multibyte characters. | |||
There was a problem hiding this comment.
This should describe the fix rather than the previous bug: The valid_docs rule now handles multibyte characters..
|
Other than the changelog entry, 👍. Nice catch. |
|
🙏 |
|
This needs to be rebased |
Check for multibyte characters in .swift
norio-nomura
force-pushed
the
nn-fix-295
branch
from
b46573b to
37d141c
Compare
|
I rebased. 🙇 |
jpsim
added a commit
that referenced
this pull request
Dec 28, 2015
Add valid_docs rule handle multibyte characters.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #295