closure_spacing accepts empty bodies with a space #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelofabri
commented
Nov 16, 2016
| let content = file.contents.substring($0.location + 1, length: $0.length - 2) | ||
| if content.isEmpty { return false } // case when {} is not a closure | ||
| if content.isEmpty || content == " " { |
There was a problem hiding this comment.
this is kind of ugly, but I didn't want to make multiple spaces valid, only {} and { }
Current coverage is 85.96% (diff: 100%)@@ master #879 diff @@
==========================================
Files 112 112
Lines 4908 4910 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 4219 4221 +2
Misses 689 689
Partials 0 0
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #875