Update weak delegate rule to only match delegate suffix #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a changelog entry? Probably under "Bug Fixes" would be best. @AliSoftware this seem reasonable to you? |
|
Done. Let me know if there's anything else! |
|
👍 |
|
Maybe we could add an entry to |
|
Looks good @philwebster, but please ping me once Travis has had a chance to catch up, and as long as everything's green we'll merge. |
Current coverage is 83.23% (diff: 100%)@@ master #923 diff @@
==========================================
Files 114 114
Lines 5136 5136
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 4275 4275
Misses 861 861
Partials 0 0
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule was warning on lines like the following line in our tests:
var createActivityDelegateMethodCalled = falseI'm not sure if anyone names their delegates with
delegateprefixed or in the middle (which this change would miss), but this seems like a reasonable modification.