Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix more typos #16

Merged
merged 1 commit into from
Jul 20, 2019
Merged

Conversation

luzpaz
Copy link
Collaborator

@luzpaz luzpaz commented Jul 20, 2019

No description provided.

@realthunder realthunder merged commit 1bf103e into realthunder:LinkMerge Jul 20, 2019
@luzpaz
Copy link
Collaborator Author

luzpaz commented Jul 20, 2019

Question (unrelated to this PR): would you consider renaming s/pathes/paths/
There are places in your code that you utilize the parameter pathes. I was hoping we could have that parameter actually be correctly spelled.

@luzpaz luzpaz deleted the LInkMerge-typo-fixes2 branch July 20, 2019 02:48
@realthunder
Copy link
Owner

Yes, sure.

@luzpaz
Copy link
Collaborator Author

luzpaz commented Jul 20, 2019

@realthunder actually nvm, looks like there would be a problem in src/App/Expressions.cpp because there is already a function that is called paths so it would conflict there.

@realthunder
Copy link
Owner

I didn't see any function named paths, just arguments. I've fixed typos now.

@dulouie dulouie mentioned this pull request Nov 8, 2020
@yahbluez yahbluez mentioned this pull request Jan 18, 2024
2 tasks
@thecoolsundar thecoolsundar mentioned this pull request Mar 31, 2024
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants