Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BR Mouse context: don't detect envelope segment when mouse cursor is outside of automation items bounds and underlying envelope is bypassed #1735

Conversation

nofishonfriday
Copy link
Collaborator

@nofishonfriday nofishonfriday commented Feb 21, 2023

fixes #1727, fixes #1488

# BR_EnvelopeUtil.h: add link to schwa's post listing AI tokens

Seems to work:
env det

function main()
  window ,segment, detail = reaper.BR_GetMouseCursorContext()
  reaper.defer(main)
end

main()

@nofishonfriday nofishonfriday force-pushed the br-mouse-ctx-fix-env-detection-AI-underl-env-bypassed branch from bf07281 to a5050ba Compare February 21, 2023 05:05
@AppVeyorBot

This comment was marked as outdated.

@nofishonfriday nofishonfriday force-pushed the br-mouse-ctx-fix-env-detection-AI-underl-env-bypassed branch 2 times, most recently from ab03165 to 6865b8b Compare February 21, 2023 06:53
@AppVeyorBot

This comment was marked as outdated.

@nofishonfriday nofishonfriday force-pushed the br-mouse-ctx-fix-env-detection-AI-underl-env-bypassed branch 2 times, most recently from 18513c3 to 7e3b8c7 Compare February 21, 2023 23:04
@AppVeyorBot

This comment was marked as outdated.

@cfillion
Copy link
Member

cfillion commented Feb 4, 2024

7e3b8c7 adds a lot of trailing whitespace:

Trailing whitespace

@nofishonfriday
Copy link
Collaborator Author

Oops, not sure how that happened, thanks.
Could/will fix in ~6 hours, but if you're currently in the process of merging and like to do it earlier go ahead. :)

…outside of automation items bounds and underlying envelope is bypassed

fixes reaper-oss#1727, fixes reaper-oss#1488
@cfillion cfillion force-pushed the br-mouse-ctx-fix-env-detection-AI-underl-env-bypassed branch from 7e3b8c7 to 9916097 Compare February 4, 2024 14:34
@Buy-One
Copy link

Buy-One commented Feb 4, 2024

Would be nice to have the new behavior documented for the end users.

@cfillion
Copy link
Member

cfillion commented Feb 4, 2024

Would be nice to have the new behavior documented for the end users.

It's a bugfix for incorrectly detecting an envelope segment under the mouse cursor where there are none when "Bypass underlying envelope outside of automation items" is enabled:

Before

With this PR applied:
After

@Buy-One
Copy link

Buy-One commented Feb 4, 2024

Ah OK, misunderstood, thought it was new feature of ignoring segments of a bypassed envelope

@cfillion cfillion merged commit 1c6d9ea into reaper-oss:master Feb 8, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
4 participants