Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

set "min" property to "string" #281

Merged
merged 1 commit into from
Apr 27, 2020
Merged

set "min" property to "string" #281

merged 1 commit into from
Apr 27, 2020

Conversation

stuartkeith
Copy link
Contributor

Related to issue #137.

The min property is currently set to be an int - however min is used for a variety of input types (number, range, date, etc), and int is not always compatible.

This PR sets it to be string instead.

@sgrove
Copy link
Contributor

sgrove commented Apr 23, 2020

Looks like this might be superseded by #442 ?

@rickyvetter rickyvetter merged commit fca1eb9 into reasonml:master Apr 27, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants