Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add binding for name and displayName #433

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

czystyl
Copy link
Contributor

@czystyl czystyl commented May 24, 2019

I added binding for name and displayName of the React Component.

Copy link
Contributor

@rickyvetter rickyvetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the super slow turnaround here. If you're not interested or can't make these changes, then no worries, I can take over and add here.

src/React.re Outdated

[@bs.get]
external getDisplayName: component('props) => Js.undefined(string) =
"displayName";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use [@bs.return nullable] on these - see #526 as an example to get a better api on the Reason side. Also I think we should make the API match and just call displayName and name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rickyvetter 🙌

[@bs.return nullable] is nice!

@rickyvetter rickyvetter merged commit 10dc1fa into reasonml:master Apr 27, 2020
@czystyl czystyl deleted the component-name branch April 28, 2020 06:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants