Fix PHP 7.0 on prefixed - skip nullable till phpstan is downgraded #6221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
TomasVotruba
changed the title
TomasVotruba
added a commit
that referenced
this pull request
Aug 6, 2024
rectorphp/rector-src@69a3e31 [CodeQuality] Skip Generator on SimplifyForeachToCoalescingRector (#6221)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samsonasik Just a note, current downgrade set for PHP 7.1 cannot be used with
phpstan.phar.It would create return type conflict, as it only downgraded our code but parent class is in
phpstan.pharThe solution is to downgrade https://github.com/phpstan/phpstan-src or unwrap
phpstan.pharand downgrade it too