Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add CredentialSecret methods #681

Closed
wants to merge 1 commit into from
Closed

Add CredentialSecret methods #681

wants to merge 1 commit into from

Conversation

max-melentyev
Copy link

So that it can be used with an interface

@max-melentyev
Add CredentialSecret methods
21ca4f5 
So that it can be used with an interface
@max-melentyev max-melentyev requested a review from a team as a code owner February 14, 2025 20:34
@max-melentyev max-melentyev requested review from fishy, konradreiche and pacejackson and removed request for a team February 14, 2025 20:34
fishy
fishy approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@fishy fishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. the failed CI will be fixed after #682 is merged and you rebase on top of that.

pacejackson
pacejackson requested changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@pacejackson pacejackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it necessary to use this as an interface?

pacejackson
pacejackson reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@pacejackson pacejackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some context, making these have an interface makes me worried that we'll start passing them around when we really should be passing around loaders. The Secret objects themselves don't ever update, you have to re-load them each time to get updates.

@max-melentyev max-melentyev deleted the max-melentyev-patch-1 branch February 18, 2025 18:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pacejackson pacejackson pacejackson requested changes

@fishy fishy fishy approved these changes

@konradreiche konradreiche Awaiting requested review from konradreiche konradreiche is a code owner automatically assigned from reddit/baseplate-go

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-melentyev @fishy @pacejackson