Fixing list_of_mail_to list generation #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list_of_mail_to list (which is used for TO: filed for SMTP) is
generated as:
"to": "[] + [ 'name@domain.com' ]",
, which causes problems with SMTP servers that are strictly follows RFC.
This commit updating list_of_mail_to generation, so the final result should
look like:
"to": [
"name@domain.com",
"first.last@domain.com"
],
oybed
requested changes
Feb 8, 2023
oybed
approved these changes
Feb 9, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
list_of_mail_tolist (which is used for the SMTPTO:field) is generated as follow, so SMTP servers which are strictly follows RFC returning errors.This PR updating
list_of_mail_togeneration, so the final result looks like:How should this be tested?
This PR was tested by sending emails using the
email-notify-list-of-users.ymlplaybook.People to notify
cc: @redhat-cop/infra-ansible