-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
odo logs: Do not panic when no access to cluster/podman #6561
odo logs: Do not panic when no access to cluster/podman #6561
Conversation
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
5f9f9a6
to
63c7321
Compare
tests/integration/cmd_logs_test.go
Outdated
When("podman is not installed", func() { | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming this needs to be removed?
pkg/odo/cli/logs/logs.go
Outdated
return errors.New("you need access to a cluster to run this command") | ||
} | ||
case commonflags.PlatformPodman: | ||
if o.clientset.PodmanClient == nil { | ||
return errors.New("you need access to podman to run this command") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase this on top of main and use the new kclient.NewNoConnectionError()
function?
Same for podman, podman.NewPodmanNotFoundError()
.
e4e084d
to
15ffeea
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after testing it.
@valaparthvi, since you initially reviewed it, please approve this PR if you are ok with the changes.
/lgtm |
/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests
|
@valaparthvi: Overrode contexts on behalf of valaparthvi: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/kind bug
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #6555
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: