Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Preference dependency to api-server command #6974

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Add Preference dependency to api-server command #6974

merged 1 commit into from
Jul 18, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jul 18, 2023

What type of PR is this:

/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6973

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 18, 2023
@netlify
Copy link

netlify bot commented Jul 18, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit db78ee2
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64b632634a2d1b0008ca6bd6

@openshift-ci openshift-ci bot requested review from anandrkskd and kadel July 18, 2023 06:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Jul 18, 2023

OpenShift Unauthenticated Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 18, 2023

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 18, 2023

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 18, 2023

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 18, 2023

Kubernetes Tests on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 18, 2023

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 18, 2023

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@rm3l
Copy link
Member

rm3l commented Jul 18, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 18, 2023
@rm3l
Copy link
Member

rm3l commented Jul 18, 2023 

  [FAILED] Expected
      <string>: I0718 06:43:27.839671   18060 version.go:41] executing [podman version --format json]
      I0718 06:43:27.840098   18060 clientset.go:225] no Podman client initialized: exec: "podman": executable file not found in $PATH
      I0718 06:43:27.840115   18060 implem.go:114] The path for preference file is /tmp/3965693837/preference.yaml
      I0718 06:43:27.840985   18060 context.go:172] absolute devfile path: '/tmp/1527793289/devfile.yaml'
      I0718 06:43:27.841034   18060 context.go:113] absolute devfile path: '/tmp/1527793289/devfile.yaml'
      I0718 06:43:27.841641   18060 content.go:48] converted devfile YAML to JSON
      I0718 06:43:27.841800   18060 apiVersion.go:60] devfile schemaVersion: '2.2.0'
      I0718 06:43:27.841944   18060 helper.go:56] devfile apiVersion '2.2.0' is supported
      I0718 06:43:27.845937   18060 schema.go:61] validated devfile schema
      I0718 06:43:27.848181   18060 validate.go:45] Successfully validated devfile sections
      I0718 06:43:27.848219   18060 validate.go:45] Successfully validated devfile sections
      I0718 06:43:27.848304   18060 component.go:87] name of component is "nqxhfi", and sanitized name is "nqxhfi"
      I0718 06:43:27.848347   18060 kclient.go:237] Checking if "projects" resource is supported
      I0718 06:43:27.872002   18060 oc_server.go:26] Trying to connect to server c110.eu-de.containers.cloud.ibm.com:32062
      I0718 06:43:27.877497   18060 oc_server.go:33] Server https://c110.eu-de.containers.cloud.ibm.com:32062 is up
      I0718 06:43:27.891991   18060 oc_server.go:66] Unable to get OpenShift Version: the server could not find the requested resource
      I0718 06:43:28.003463   18060 jobs.go:44] Waiting for Job nqxhfi-app-deploy-exec to complete successfully
      I0718 06:43:36.386917   18060 jobs.go:67] Failed to execute the job, reason: &JobCondition{Type:Failed,Status:True,LastProbeTime:2023-07-18 06:43:36 +0000 UTC,LastTransitionTime:2023-07-18 06:43:36 +0000 UTC,Reason:BackoffLimitExceeded,Message:Job has reached the specified backoff limit,}
      counter 1 counter
      counter 2 counter
      counter 3 counter
      counter 4 counter
      counter 5 counter
      counter 6 counter
      counter 7 counter
      counter 8 counter
      counter 9 counter
      counter 10 counter
      counter 11 counter
      counter 12 counter
      counter 13 counter
      counter 14 counter
      counter 15 counter
      counter 16 counter
      counter 17 counter
      counter 18 counter
      counter 19 counter
      counter 20 counter
      counter 21 counter
      counter 22 counter
      counter 23 counter
      counter 24 counter
      counter 25 counter
      counter 26 counter
      counter 27 counter
      counter 28 counter
      counter 29 counter
      counter 30 counter
      counter 31 counter
      counter 32 counter
      counter 33 counter
      counter 34 counter
      counter 35 counter
      counter 36 counter
      counter 37 counter
      counter 38 counter
      counter 39 counter
      counter 40 counter
      counter 41 counter
      counter 42 counter
      counter 43 counter
      counter 44 counter
      counter 45 counter
      counter 46 counter
      counter 47 counter
      counter 48 counter
      counter 49 counter
      counter 50 counter
      counter 51 counter
      counter 52 counter
      counter 53 counter
      counter 54 counter
      counter 55 counter
      counter 56 counter
      counter 57 counter
      counter 58 counter
      counter 59 counter
      counter 60 counter
      counter 61 counter
      counter 62 counter
      counter 63 counter
      counter 64 counter
      counter 65 counter
      counter 66 counter
      counter 67 counter
      counter 68 counter
      counter 69 counter
      counter 70 counter
      counter 71 counter
      counter 72 counter
      counter 73 counter
      counter 74 counter
      counter 75 counter
      counter 76 counter
      counter 77 counter
      counter 78 counter
      counter 79 counter
      counter 80 counter
      counter 81 counter
      counter 82 counter
      counter 83 counter
      counter 84 counter
      counter 85 counter
      counter 86 counter
      cou...

  Gomega truncated this representation as it exceeds 'format.MaxLength'.
  Consider having the object provide a custom 'GomegaStringer' representation
  or adjust the parameters in Gomega's 'format' package.

  Learn more here: https://onsi.github.io/gomega/#adjusting-output

  not to contain substring
      <string>: counter 1 counter
...
Summarizing 1 Failure:
  [FAIL] odo devfile deploy command tests deploying devfile with exec when using devfile where the exec command is bound to fail [It] should print the last 100 lines of the log to the output
  /go/odo_1/tests/integration/cmd_devfile_deploy_test.go:652

Ran 403 of 940 Specs in 1239.320 seconds
FAIL! -- 402 Passed | 1 Failed | 0 Pending | 537 Skipped

Flaky odo logs test - unrelated.

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

@openshift-ci
Copy link

openshift-ci bot commented Jul 18, 2023

@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

In response to this:

 [FAILED] Expected
     <string>: I0718 06:43:27.839671   18060 version.go:41] executing [podman version --format json]
     I0718 06:43:27.840098   18060 clientset.go:225] no Podman client initialized: exec: "podman": executable file not found in $PATH
     I0718 06:43:27.840115   18060 implem.go:114] The path for preference file is /tmp/3965693837/preference.yaml
     I0718 06:43:27.840985   18060 context.go:172] absolute devfile path: '/tmp/1527793289/devfile.yaml'
     I0718 06:43:27.841034   18060 context.go:113] absolute devfile path: '/tmp/1527793289/devfile.yaml'
     I0718 06:43:27.841641   18060 content.go:48] converted devfile YAML to JSON
     I0718 06:43:27.841800   18060 apiVersion.go:60] devfile schemaVersion: '2.2.0'
     I0718 06:43:27.841944   18060 helper.go:56] devfile apiVersion '2.2.0' is supported
     I0718 06:43:27.845937   18060 schema.go:61] validated devfile schema
     I0718 06:43:27.848181   18060 validate.go:45] Successfully validated devfile sections
     I0718 06:43:27.848219   18060 validate.go:45] Successfully validated devfile sections
     I0718 06:43:27.848304   18060 component.go:87] name of component is "nqxhfi", and sanitized name is "nqxhfi"
     I0718 06:43:27.848347   18060 kclient.go:237] Checking if "projects" resource is supported
     I0718 06:43:27.872002   18060 oc_server.go:26] Trying to connect to server c110.eu-de.containers.cloud.ibm.com:32062
     I0718 06:43:27.877497   18060 oc_server.go:33] Server https://c110.eu-de.containers.cloud.ibm.com:32062 is up
     I0718 06:43:27.891991   18060 oc_server.go:66] Unable to get OpenShift Version: the server could not find the requested resource
     I0718 06:43:28.003463   18060 jobs.go:44] Waiting for Job nqxhfi-app-deploy-exec to complete successfully
     I0718 06:43:36.386917   18060 jobs.go:67] Failed to execute the job, reason: &JobCondition{Type:Failed,Status:True,LastProbeTime:2023-07-18 06:43:36 +0000 UTC,LastTransitionTime:2023-07-18 06:43:36 +0000 UTC,Reason:BackoffLimitExceeded,Message:Job has reached the specified backoff limit,}
     counter 1 counter
     counter 2 counter
     counter 3 counter
     counter 4 counter
     counter 5 counter
     counter 6 counter
     counter 7 counter
     counter 8 counter
     counter 9 counter
     counter 10 counter
     counter 11 counter
     counter 12 counter
     counter 13 counter
     counter 14 counter
     counter 15 counter
     counter 16 counter
     counter 17 counter
     counter 18 counter
     counter 19 counter
     counter 20 counter
     counter 21 counter
     counter 22 counter
     counter 23 counter
     counter 24 counter
     counter 25 counter
     counter 26 counter
     counter 27 counter
     counter 28 counter
     counter 29 counter
     counter 30 counter
     counter 31 counter
     counter 32 counter
     counter 33 counter
     counter 34 counter
     counter 35 counter
     counter 36 counter
     counter 37 counter
     counter 38 counter
     counter 39 counter
     counter 40 counter
     counter 41 counter
     counter 42 counter
     counter 43 counter
     counter 44 counter
     counter 45 counter
     counter 46 counter
     counter 47 counter
     counter 48 counter
     counter 49 counter
     counter 50 counter
     counter 51 counter
     counter 52 counter
     counter 53 counter
     counter 54 counter
     counter 55 counter
     counter 56 counter
     counter 57 counter
     counter 58 counter
     counter 59 counter
     counter 60 counter
     counter 61 counter
     counter 62 counter
     counter 63 counter
     counter 64 counter
     counter 65 counter
     counter 66 counter
     counter 67 counter
     counter 68 counter
     counter 69 counter
     counter 70 counter
     counter 71 counter
     counter 72 counter
     counter 73 counter
     counter 74 counter
     counter 75 counter
     counter 76 counter
     counter 77 counter
     counter 78 counter
     counter 79 counter
     counter 80 counter
     counter 81 counter
     counter 82 counter
     counter 83 counter
     counter 84 counter
     counter 85 counter
     counter 86 counter
     cou...

 Gomega truncated this representation as it exceeds 'format.MaxLength'.
 Consider having the object provide a custom 'GomegaStringer' representation
 or adjust the parameters in Gomega's 'format' package.

 Learn more here: https://onsi.github.io/gomega/#adjusting-output

 not to contain substring
     <string>: counter 1 counter
...
Summarizing 1 Failure:
 [FAIL] odo devfile deploy command tests deploying devfile with exec when using devfile where the exec command is bound to fail [It] should print the last 100 lines of the log to the output
 /go/odo_1/tests/integration/cmd_devfile_deploy_test.go:652

Ran 403 of 940 Specs in 1239.320 seconds
FAIL! -- 402 Passed | 1 Failed | 0 Pending | 537 Skipped

Flaky odo logs test - unrelated.

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 53cb806 into redhat-developer:main Jul 18, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@kadel kadel Awaiting requested review from kadel

Assignees

@rm3l rm3l

Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Saving the Devfile fails when api served with odo --api-server
3 participants
@feloy @rm3l @openshift-merge-robot