move .eslintrc.js to .eslintrc to fix issues... #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickboldt
force-pushed
the
fix-module-errors
branch
from
0b9bd89 to
3203626
Compare
…s files Signed-off-by: Nick Boldt <nboldt@redhat.com> remove eslint-disable now that we can use it for .mjs modules Signed-off-by: Nick Boldt <nboldt@redhat.com>
…on ./scripts/*.mjs now that the eslint config is fixed Signed-off-by: Nick Boldt <nboldt@redhat.com>
nickboldt
force-pushed
the
fix-module-errors
branch
from
3203626 to
5127ba2
Compare
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: schultzp2020 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The image is available at: |
9 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
move .eslintrc.js to .eslintrc to fix issues with using import in .mjs files
Signed-off-by: Nick Boldt nboldt@redhat.com
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
N/A (or see commit message above for issue number)
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.