Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(e2e): skip PR build for changes limited to e2e folder or existing image #2135

Merged

Conversation

gustavolira
Copy link
Contributor

@gustavolira gustavolira commented Dec 22, 2024

Description

https://issues.redhat.com/browse/RHIDP-5538

Add steps to detect PRs with changes only in the e2e/ folder and skip the build in such cases. Additionally, check if the image already exists in Quay.io and bypass the build if it does. This reduces unnecessary builds, improving efficiency in the CI workflow.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@gustavolira gustavolira requested a review from a team as a code owner December 22, 2024 20:40
Copy link
Contributor

Copy link
Contributor

@gustavolira gustavolira changed the title Skip PR build for changes limited to e2e folder or existing image chore(e2e): skip PR build for changes limited to e2e folder or existing image Dec 23, 2024
Add steps to detect PRs with changes only in the `e2e/` folder and skip the build in such cases. Additionally, check if the image already exists in Quay.io and bypass the build if it does. This reduces unnecessary builds, improving efficiency in the CI workflow.
Copy link
Contributor

Copy link
Collaborator

@josephca josephca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ee3bde5 into redhat-developer:main Jan 14, 2025
11 checks passed
calebevans pushed a commit to calebevans/rhdh that referenced this pull request Jan 15, 2025
…dhat-developer#2135)

Add steps to detect PRs with changes only in the `e2e/` folder and skip the build in such cases. Additionally, check if the image already exists in Quay.io and bypass the build if it does. This reduces unnecessary builds, improving efficiency in the CI workflow.
zdrapela added a commit to zdrapela/rhdh that referenced this pull request Jan 16, 2025
Skip PR build for changes limited to e2e folder or existing image (redhat-developer#2135)

Add steps to detect PRs with changes only in the `e2e/` folder and skip the build in such cases. Additionally, check if the image already exists in Quay.io and bypass the build if it does. This reduces unnecessary builds, improving efficiency in the CI workflow.
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants