fix: improve selection of webview #1727
Conversation
pollend
force-pushed
the
bugfix/improve-selection-webview
branch
from
f4fc8a7 to
0b2cc9e
Compare
| @@ -627,7 +627,7 @@ export async function findBestContainingElement(container: IRectangle, testEleme | |||
| const ax = Math.max(container.x, rect.x); | |||
| const ay = Math.max(container.y, rect.y); | |||
| const bx = Math.min(container.x + container.width, rect.x + rect.width); | |||
| const by = Math.min(container.y + container.width, rect.y + rect.height); | |||
| const by = Math.min(container.y + container.height, rect.y + rect.height); | |||
There was a problem hiding this comment.
I made a small mistake here.
djelinek
force-pushed
the
bugfix/improve-selection-webview
branch
from
6c88fcb to
6ce70bb
Compare
|
Hello, From top of my head, it would be nice to also have test cases which are handling multiple WebView types opened at same time. Basically it can happen state when, Editor WebView / BottomBar WebView and SideBar WebView are open/visible at same time. This is a edge case which was reported in a past also |
I have one test where I open multiple grouped webview but are you saying I should add another test for BottomBar/Editor Webview and Editor Webview/sidebar |
That is awesome what you have added, it brings a value. I am more expressing my first thoughts here about complexity of problem. What I am saying is that we need to cover also case, mentioned above, with multiple webviews of different kind opened in a same time, probably in a new standalone test. It can be also checked manually if this is working and we can provide other test in another PR. I am just raising it to not forget about that 🙂 |
ref: redhat-developer#1492 Signed-off-by: Michael Pollind <quic_mpollind@quicinc.com>
Signed-off-by: Michael Pollind <quic_mpollind@quicinc.com>
Signed-off-by: Michael Pollind <quic_mpollind@quicinc.com>
Signed-off-by: Michael Pollind <<quic_mpollind@quicinc.com>
Signed-off-by: Michael Pollind <quic_mpollind@quicinc.com>
djelinek
force-pushed
the
bugfix/improve-selection-webview
branch
from
6ce70bb to
ac99444
Compare
djelinek
changed the title
djelinek
added
ready-for-review
|
sorry, for the lack of response I've been on a bit of a trip. I'll see if I can address your comments by the end of this week. |
Signed-off-by: Michael Pollind <quic_mpollind@quicinc.com>
|
|
I am eagerly waiting this issue to be fixed. I am facing an issue with multiple web views on the page—one in the sidebar and another in the editor. After the sidebar view is launched, I am unable to locate the editor web view. Could you please help me resolve this? I have already tried using the |
|
Hello, @djelinek where have we left off, is there anything else that needs to be address? |
I played with a couple of solutions; sometimes there is an id that links the view back to the containing webview but that is not consistent across vscode. The main issue is the webviews are elevated to the top of the dom so you can't easily tell if that webview is associated with a given element. Testing the overlap seems the most consistent way to approach this?
ref: #1492