Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add actions to configure functions #174

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Conversation

lstocchi
Copy link
Contributor

@lstocchi lstocchi commented Feb 3, 2022

it resolves #164

As in IJ, there are two actions (add/remove config) which allow users to add/remove env variables/volumes.
config-function

@evidolob @jeffmaury if any of you have some free time to review it, it would be great.

Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #174 (afc969a) into main (5a175dc) will increase coverage by 0.19%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   93.16%   93.35%   +0.19%     
==========================================
  Files          72       74       +2     
  Lines        2866     2888      +22     
  Branches      458      460       +2     
==========================================
+ Hits         2670     2696      +26     
+ Misses        196      192       -4     
Impacted Files Coverage Δ
src/extension.ts 80.00% <50.00%> (-2.36%) ⬇️
src/cli/func-api.ts 70.00% <100.00%> (+4.09%) ⬆️
src/functions/function-command/add-env-function.ts 100.00% <100.00%> (ø)
.../functions/function-command/remove-env-function.ts 100.00% <100.00%> (ø)
src/util/watch.ts 96.66% <0.00%> (+3.33%) ⬆️
src/cli/cmdCli.ts 53.62% <0.00%> (+4.34%) ⬆️
src/util/platform.ts 100.00% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a175dc...afc969a. Read the comment docs.

… volumes

Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
@lstocchi lstocchi changed the title Add actions to configure env variables Add actions to configure functions Feb 4, 2022
@lstocchi lstocchi marked this pull request as ready for review February 4, 2022 13:13
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can't we have sub menus like in IntelliJ ?

Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
@lstocchi
Copy link
Contributor Author

lstocchi commented Feb 7, 2022

Added submenus as in IJ. I also left the command from command palette.

knative-submenu

@lstocchi lstocchi requested a review from jeffmaury February 7, 2022 11:18
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lstocchi lstocchi merged commit da335a9 into redhat-developer:main Feb 7, 2022
@lstocchi lstocchi deleted the i164-1 branch February 7, 2022 16:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support configuration of functions for env and volumes
3 participants