-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add actions to configure functions #174
Conversation
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 93.16% 93.35% +0.19%
==========================================
Files 72 74 +2
Lines 2866 2888 +22
Branches 458 460 +2
==========================================
+ Hits 2670 2696 +26
+ Misses 196 192 -4
Continue to review full report at Codecov.
|
… volumes Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can't we have sub menus like in IntelliJ ?
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
it resolves #164
As in IJ, there are two actions (add/remove config) which allow users to add/remove env variables/volumes.

@evidolob @jeffmaury if any of you have some free time to review it, it would be great.