Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

notify user if deploying function in different namespace #239

Merged
merged 4 commits into from
Apr 21, 2022

Conversation

sudhirverma
Copy link
Contributor

Fix: #235

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2022

Codecov Report

Merging #239 (f31113c) into main (cd4b4ab) will increase coverage by 0.04%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   85.23%   85.28%   +0.04%     
==========================================
  Files          77       77              
  Lines        3115     3125      +10     
  Branches      524      530       +6     
==========================================
+ Hits         2655     2665      +10     
  Misses        460      460              
Impacted Files Coverage Δ
...ions/function-command/build-and-deploy-function.ts 87.36% <81.81%> (-0.87%) ⬇️
src/cli/func-api.ts 50.00% <100.00%> (ø)
.../functions/function-tree-view/functionsTreeItem.ts 36.36% <0.00%> (+3.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd4b4ab...f31113c. Read the comment docs.

@sudhirverma sudhirverma requested a review from lstocchi April 21, 2022 12:02
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudhirverma sudhirverma merged commit 9797929 into redhat-developer:main Apr 21, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User is not notified if the func.yaml namespace is different from the active one
3 participants